feat: implement the generic map functions from the WDL standardy library. #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements the `as_pairs` function from the WDL standard library.
This commit implements the `as_map` function from the WDL standard library.
This commit implements the `keys` function from the WDL standard library.
This commit implements the `contains_key` function from the WDL standard library. It also corrects a few issues discovered during testing: * Map values in `wdl-engine` should accept `None` for a key. * Common type calculation now supports discovering common types between the compound types containing `Union` and `None` as inner types, e.g. `Array[String] | Array[None] -> Array[String?]` * The "required primitive type" constraint has been removed as every place the constraint was used should allow for optional primitive types as well; consequently, the `AnyPrimitiveTypeConstraint` was renamed to simply `PrimitiveTypeConstraint`. * The common type calculation now favors the "left-hand side" of the calculation rather than the right, making it more intuitive to use. For example, a calculation of `File | String` is now `File` rather than `String`. Added test cases to existing functions that accept maps with optional primitive keys.
This commit implements the `values` function from the WDL standard library.
This commit implements the `collect_by_key` function from the WDL standard library.
claymcleod
reviewed
Nov 21, 2024
| .unwrap(); | ||
| assert!(value.unwrap_boolean()); | ||
|
|
||
| let value = eval_v1_expr( |
There was a problem hiding this comment.
Should we also test baz after this?
There was a problem hiding this comment.
So that I better understand, what would be the expression to test?
There was a problem hiding this comment.
We do test ['bar', 'baz'] further below (should be true), if that's what you mean.
Otherwise, a test for ['baz'] would be the same as a test for ['qux'] here (neither are keys of the Foo struct); I can change the test to use baz instead, though.
There was a problem hiding this comment.
I'm going to merge this as-is and put up a follow-up PR if warranted after discussion.
a-frantz
approved these changes
Nov 21, 2024
claymcleod
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the following WDL standard library functions:
as_pairsas_mapkeyscontains_keyvaluescollect_by_keyIt also corrects a few issues discovered during testing:
wdl-engineshould acceptNonefor a key.compound types containing
UnionandNoneas inner types, e.g.Array[String] | Array[None] -> Array[String?]constraint was used should allow for optional primitive types as well;
consequently, the
AnyPrimitiveTypeConstraintwas renamed to simplyPrimitiveTypeConstraint.calculation rather than the right, making it more intuitive to use. For
example, a calculation of
File | Stringis nowFilerather thanString.Added test cases to existing functions that accept maps with optional primitive keys.
Before submitting this PR, please make sure:
changes (when appropriate).
CHANGELOG.md(see"keep a changelog" for more information).