feat: break refresh opt into bless and update
#261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adthrasher
reviewed
Nov 27, 2024
| @@ -380,7 +385,7 @@ pub async fn gauntlet(args: Args) -> Result<()> { | |||
|
|
|||
| println!("\nTotal analysis time: {total_time:?}"); | |||
|
|
|||
| if args.refresh { | |||
| if args.bless || args.update { | |||
There was a problem hiding this comment.
Should this only fire on --bless
There was a problem hiding this comment.
No, we need to save the new diagnostics (and new hashes) back to the relevant config file when --update is passed. Otherwise --update would be a no-op that fails whenever something changed.
claymcleod
reviewed
Dec 4, 2024
claymcleod
reviewed
Dec 4, 2024
claymcleod
approved these changes
Dec 4, 2024
Co-authored-by: Clay McLeod <3411613+claymcleod@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the problem or feature in addition to a link to the issues.
closes #226
Before submitting this PR, please make sure:
changes (when appropriate).
CHANGELOG.md(see"keep a changelog" for more information).