Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pretty print HTML #270

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: pretty print HTML #270

wants to merge 5 commits into from

Conversation

a-frantz
Copy link
Member

@a-frantz a-frantz commented Dec 16, 2024

Describe the problem or feature in addition to a link to the issues.

Update wdl-doc to pretty print HTML. Achieved via the Debug format of the html crate.

Before submitting this PR, please make sure:

  • You have added a few sentences describing the PR here.
  • You have added yourself or the appropriate individual as the assignee.
  • You have added at least one relevant code reviewer to the PR.
  • Your code builds clean without any errors or warnings.
  • You have added tests (when appropriate).
  • You have updated the README or other documentation to account for these
    changes (when appropriate).
  • You have added an entry to the relevant CHANGELOG.md (see
    "keep a changelog" for more information).
  • Your commit messages follow the conventional commit style.

@a-frantz a-frantz self-assigned this Dec 16, 2024
@a-frantz a-frantz marked this pull request as ready for review December 16, 2024 21:51
wdl-doc/CHANGELOG.md Outdated Show resolved Hide resolved
<h1>
FlagFilter
</h1><ul>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this needs some newlines.

Copy link
Member

@claymcleod claymcleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see what the results look like when you add the newline to the print statements.

a-frantz and others added 2 commits December 16, 2024 18:15
Co-authored-by: Clay McLeod <3411613+claymcleod@users.noreply.github.com>
@a-frantz a-frantz requested a review from claymcleod December 16, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants