refactor: make Analyzer
accept the diagnostics configuration.
#274
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the
new
andnew_with_validator
methods ofAnalyzer
to directly accept theDiagnosticsConfig
rather than an iterator of rules which it immediately uses to create aDiagnosticsConfig
internally.By having the
DiagnosticsConfig
(which isCopy
) passed in directly, we don't have to borrow a rule exception list that might also be used as part of the validator closure passed tonew_with_validator
, sparing us a clone.Before submitting this PR, please make sure:
changes (when appropriate).
CHANGELOG.md
(see"keep a changelog" for more information).