Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ImportSort and ImportWhitespace changes #98

Merged
merged 7 commits into from
Jun 24, 2024
Merged

Conversation

a-frantz
Copy link
Member

@a-frantz a-frantz commented Jun 24, 2024

This pull request adds a new rule to wdl-lint (and changes an existing rule).

  • Rule Name: ImportSort and ImportWhitespace

Describe the rules you have implemented and link to any relevant issues.

Before submitting this PR, please make sure:

  • You have added a few sentences describing the PR here.
  • You have added yourself or the appropriate individual as the assignee.
  • You have added at least one relevant code reviewer to the PR.
  • Your code builds clean without any errors or warnings.
  • You have added an entry to the relevant CHANGELOG.md (see
    "keep a changelog" for more information).
  • Your commit messages follow the conventional commit style.

Rule specific checks:

  • You have added the rule as an entry within RULES.md.
  • You have added the rule to the rules() function in wdl-lint/src/lib.rs.
  • You have added a test cases in wdl-lint/tests/lints that covers every
    possible diagnostic emitted for the rule within the file where the rule
    is implemented.
  • You have run wdl-gauntlet --refresh to ensure that there are no
    unintended changes to the baseline configuration file (Gauntlet.toml).
  • You have run wdl-gauntlet --refresh --arena to ensure that all of the
    rules added/removed are now reflected in the baseline configuration file
    (Arena.toml).

@a-frantz a-frantz self-assigned this Jun 24, 2024
@a-frantz a-frantz marked this pull request as ready for review June 24, 2024 13:29
adthrasher
adthrasher previously approved these changes Jun 24, 2024
@adthrasher adthrasher self-requested a review June 24, 2024 13:55
@adthrasher adthrasher dismissed their stale review June 24, 2024 13:55

Only saw most recent commit

wdl-lint/src/rules/import_sort.rs Outdated Show resolved Hide resolved
wdl-lint/src/rules/import_whitespace.rs Outdated Show resolved Hide resolved
a-frantz and others added 2 commits June 24, 2024 10:15
Co-authored-by: Andrew Thrasher <adthrasher@gmail.com>
@a-frantz a-frantz merged commit 044cddb into main Jun 24, 2024
7 checks passed
@a-frantz a-frantz deleted the a-frantz/import-sort branch June 24, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants