Updates the pipeline to validate that packaging a jar works properly #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnjaylward
changed the title
|
@stleary can you re-run the last set of jobs, they worked on branch, but not in the PR for some reason |
Merged
added 3 commits
October 16, 2023 15:36
johnjaylward
force-pushed
the
updateActionsForDeploy
branch
from
19b6dff
to
f7ea118
Compare
johnjaylward
force-pushed
the
updateActionsForDeploy
branch
from
f7ea118
to
3894483
Compare
|
@stleary , this is ready for review now. |
|
Nice work, thanks! |
stleary
approved these changes
Oct 20, 2023
stleary
added
hacktoberfest-accepted
and removed
Approved - 3-day window
hacktoberfest-accepted
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #796
See also #793, #761 and #760
What problem does this code solve?
Re-adds proper support for Modules on Java 9+. PR #761 was not tested with builds using JDK 8 and the changes only worked when using JDK 9+.
mvn packagestep completes during the pipelineA Follow-on PR that enables distribution through GitHub Actions would be worthwhile.
Risks
Low. Changes add new steps to the GitHub actions to ensure that packaging works properly going forward and will only affect the JAR creation
Changes to the API?
None
Will this require a new release?
Yes
Should the documentation be updated?
No, but slight changes were made to the README to:
Does it break the unit tests?
No. New GitHub actions were added to ensure that similar changes will not break release management going forward.
Was any code refactored in this commit?
No.
Review status
APPROVED
Starting 3-day comment window