ci: test with Java 21 #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have added this to PR #801 |
Thanks for letting me know. Your change seems to be doing two things at once and it is probably best to handle them separately as it would be easier to revert if needed I am leaving this open for now and I'll leave it up to the maintainers to decide |
|
good point, I'll keep the current 8-17 in my PR. we can use this one for ensuring 21 works without issue as well |
|
What problem does this code solve? Risks Changes to the API? Will this require a new release? Should the documentation be updated? Does it break the unit tests? Was any code refactored in this commit? Review status Starting 3-day comment window |
stleary
added
Approved - 3-day window
hacktoberfest-accepted
and removed
Hacktoberfest
labels
javadev
reviewed
Oct 19, 2023
javadev
approved these changes
Oct 20, 2023
stleary
previously approved these changes
Oct 20, 2023
stleary
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Java 21 to the build matrix