Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transactional i2c #445

Closed
burrbull opened this issue Feb 12, 2022 · 1 comment · Fixed by #542
Closed

transactional i2c #445

burrbull opened this issue Feb 12, 2022 · 1 comment · Fixed by #542
Labels
help wanted Extra attention is needed

Comments

@burrbull
Copy link
Contributor

Although #443 was merged new Transactional API are still not implemented:

stm32f4xx-hal/src/i2c/hal_1.rs

Line 65 in aa934ca

todo!()

stm32f4xx-hal/src/spi/hal_1.rs

Line 172 in aa934ca

_ => todo!(),

@burrbull burrbull added the help wanted Extra attention is needed label Feb 12, 2022
@burrbull
Copy link
Contributor Author

@ryankurte as you are interested in this hal could you help with this issue?

@ryankurte ryankurte mentioned this issue Mar 13, 2022
Merged
bors bot added a commit that referenced this issue Mar 15, 2022
@bors @ryankurte
Merge #464
3a87906 
464: Added transactional SPI implementation r=burrbull a=ryankurte

per #445, i don't have a moment to look at the I2C at the moment as the behaviour is a bit more complex wrt. where starts and ends get asserted.

Co-authored-by: ryan kurte <ryankurte@gmail.com>
@burrbull burrbull changed the title transactional i2c/spi transactional i2c Mar 30, 2022
@SpeedCrash100 SpeedCrash100 mentioned this issue Oct 18, 2022
Merged
@bors bors bot closed this as completed in 6d0c292 Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Transactional I2C SpeedCrash100/stm32f4xx-hal
1 participant
@burrbull