Transactional I2C #542
Merged
Transactional I2C #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Is it tested? |
I have tested on operations sequences Write-Write and Write-Read, and single Write. No problems detected in these cases. |
burrbull
approved these changes
Oct 18, 2022
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A transactional HAL API implementation for I2C. Closes #445.
I have to rework i2c code to implement this:
prepare_read,prepare_write- methods to send start and address onlywrite_wo_prepare,read_wo_prepare- methods like oldread,writebut they do not send start and address.read_bytes,write_bytes- this methods now only for send/receive. The do not send start, stop or address.Note: I have to create duplicate methods
transaction_sliceandtransactionbecauseOperationdoesn't implement Clone to send slice as iterator.