Support for I2C #26
Merged
Support for I2C #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 27, 2021 10:09
Most of this code is taken from stm32g0xx-hal, with only minor changes to the way pins are initialized and to the interaction with RCC.
The std::max() meant that scll was always set to 255, resulting in bit rates that were far too slow. Also, the documentation states that the clock is divided by PRESC+1, not by 2^(PRESC+1).
|
After I fixed a bug in the original code (see stm32-rs/stm32g0xx-hal#69), the pull request should now be ready for review/merging. For testing, I executed the i2c-mpu6050 example and verified with an oscilloscope that the bit rate is correct. |
|
Oh, and tell me if you want the commits to be squashed, as I usually do. |
|
This looks good to me, thank you for your effort! Squashing can be done from by Github. |
luctius
pushed a commit
to luctius/stm32g4xx-hal
that referenced
this pull request
Sep 17, 2021
* Add support for I2C. Most of this code is taken from stm32g0xx-hal, with only minor changes to the way pins are initialized and to the interaction with RCC. * Improve the I2C documentation. * Fix compiler error for devices without I2C4. * Add an I2C/MPU6050 example (the timing is still broken). * Fix the I2C bit rate. The std::max() meant that scll was always set to 255, resulting in bit rates that were far too slow. Also, the documentation states that the clock is divided by PRESC+1, not by 2^(PRESC+1).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for I2C. Most of the code is taken from
stm32g0xx-hal, with only minor changes:I personally do not like the way the bus is configured -
with_timing()imho is not the kind of abstraction that should be in a user-facing API. I guess that there are workflows that require this API, though.The code is not yet tested - it should be ready for merging once I have performed some basic tests.