Skip to content

HCI data length configuration option #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 13 commits into from
Closed

HCI data length configuration option #37

wants to merge 13 commits into from

Conversation

KMeldgaard
Copy link

Implemented hci_le_set_data_length on connection with a BLE central.

KMeldgaard and others added 13 commits November 15, 2021 09:35
@fpistm fpistm requested review from cparata and FRASTM and removed request for cparata November 25, 2021 10:30
FRASTM
FRASTM reviewed Dec 1, 2021
View reviewed changes
README.md Outdated
STM32Cube_WPAN has several configuration options, which are set in the `app_conf.h`.
This package has a default configuration named `app_conf_default.h`.
The user can include the file `app_conf_custom.h` to customize the ble application. Options wrapped in `#ifndef, #endif` in `app_conf_default.h` can be overwritten. Additional options can be added.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The app_conf.h file is directly taken from the STM32CubeWB Applications/BLE,
Could this inclusion be organised to keep app_conf.h

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @FRASTM

Is this reworked in the latest PR #38 ?

I haven't had time to dive into this the past week.

Regards

@fpistm
Copy link
Member

fpistm commented Dec 10, 2021

Hi @KMeldgaard
As Length configuration is an HCI Commands, your PR should be added to the official Arduino BLE library then we will inherit from it. As we are sync to it, add it here first will add extra effort for the sync.
That's why I close this PR and hope it will be added to the official arduino BLE.

@fpistm fpistm closed this Dec 10, 2021
@fpistm fpistm added the wontfix This will not be worked on label Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRASTM FRASTM FRASTM left review comments

Assignees
No one assigned
Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KMeldgaard @fpistm @FRASTM