Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🤖 Sync from open-cluster-management-io/config-policy-controller: #118 #465

Merged
merged 1 commit into from
Apr 6, 2023
Merged

🤖 Sync from open-cluster-management-io/config-policy-controller: #118 #465

merged 1 commit into from
Apr 6, 2023

Conversation

magic-mirror-bot[bot]
Copy link

@mprahl
Use patches for adding and removing finalizers
2c00e9a 
Using update can have unintended consequences such as setting empty
values of fields that were nil on the server. This happens for
the evaluationInterval field where if it wasn't set, the update adds an
empty map, which triggers the spec-sync to remove the nil map. This
unnecessary spec-sync update causes the status update to fail later on
in the ConfigurationPolicy processing.

Additionally, when a finalizer can't be added or removed, the evaluation
stops and would be retried on the next run. This is a safer approach.

Signed-off-by: mprahl <mprahl@users.noreply.github.com>
(cherry picked from commit bdd6450)
@openshift-ci
Copy link

openshift-ci bot commented Apr 6, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: magic-mirror-bot[bot]
Once this PR has been reviewed and has the lgtm label, please assign mprahl for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarcloud
Copy link

sonarcloud bot commented Apr 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

45.0% 45.0% Coverage
0.0% 0.0% Duplication

@magic-mirror-bot magic-mirror-bot bot merged commit d6cc253 into main Apr 6, 2023
@magic-mirror-bot magic-mirror-bot bot deleted the magic-mirror-main-1680803184015 branch April 6, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dco-signoff: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mprahl