Commits on Apr 6, 2023

1. Use patches for adding and removing finalizers …

   Using update can have unintended consequences such as setting empty
   values of fields that were nil on the server. This happens for
   the evaluationInterval field where if it wasn't set, the update adds an
   empty map, which triggers the spec-sync to remove the nil map. This
   unnecessary spec-sync update causes the status update to fail later on
   in the ConfigurationPolicy processing.
   
   Additionally, when a finalizer can't be added or removed, the evaluation
   stops and would be retried on the next run. This is a safer approach.
   
   Signed-off-by: mprahl <mprahl@users.noreply.github.com>
   (cherry picked from commit bdd6450)

   

   mprahl authored and Magic Mirror committed Apr 6, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 2c00e9a
   • Browse repository at this point

   Copy the full SHA

   2c00e9a View commit details

   Browse the repository at this point in the history