🤖 Sync from open-cluster-management-io/config-policy-controller: #235, #238 #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![magic-mirror-bot[bot]](https://avatars.githubusercontent.com/u/60207193?s=60&v=4){kind=small}
The framework-addon now handles emitting compliance events for those errors for all template policy types. Refs: - https://issues.redhat.com/browse/ACM-10858 Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com> (cherry picked from commit 01437a4)
The Subscription and OperatorGroup fields can now utilize templates. The resolver uses the DynamicWatcher already used by the controller, so no additional plumbing was needed for new watches or in order to share a cache. Refs: - https://issues.redhat.com/browse/ACM-10858 Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com> (cherry picked from commit 1ecc347)
The library now does the DeepCopy for us, to prevent accidental mutations to objects in the cache. Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com> (cherry picked from commit b080562)
From some test runs, it seems like some of the 3.8.x releases do not always have the quayecosystems CRD, which makes the tests inconsistent. From what I can tell, *none* of the 3.10.x releases will have that CRD, so it should be consistent. Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com> (cherry picked from commit cf5224b)
This test started failing relatively often. Debugging revealed that the Subscription was getting into a ResolutionFailed=True condition, but that it did not have the expected ConstraintsNotSatisfiable reason; it looked like it was failing to resolve because the connection was refused to the catalog. Refs: - https://issues.redhat.com/browse/ACM-11414 Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com> (cherry picked from commit d02b4b9)
The full policy status is often helpful when understanding what might be unexpectedly happening in some of the operatorpolicy tests. Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com> (cherry picked from commit edc02a5)
This should help with some consistency. Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com> (cherry picked from commit 188daa6)
This creates a separate slice rather than potentially mutating the underlying array of the policy.Spec.Versions slice. Signed-off-by: mprahl <mprahl@users.noreply.github.com> (cherry picked from commit 2aa720c)
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: magic-mirror-bot[bot] The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syncing the following PRs:
This replaces #844.