Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(StoneDB 8.0): thd->no_errors no_errors is deleted #574

Closed
lujiashun opened this issue Sep 26, 2022 · 0 comments
Closed

feature(StoneDB 8.0): thd->no_errors no_errors is deleted #574

lujiashun opened this issue Sep 26, 2022 · 0 comments
Labels
A-feature feature with good idea

Comments

@lujiashun
Copy link

lujiashun commented Sep 26, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.

mysql/mysql-server@9fce6b0

in the mysql commit, we can see that is_errors is deleted directly almost. But check the code, like the
the items related function, push_warning|my_error is used to mark errors. So use is_error is a better solution.

Describe the solution you'd like

adapt the code of mysql8.0
Describe alternatives you've considered

just delete the function.
Additional context
@lujiashun lujiashun added the A-feature feature with good idea label Sep 26, 2022
@lujiashun lujiashun changed the title feature(StoneDB 8.0): fix: thd->no_errors no_errors is deleted feature(StoneDB 8.0): thd->no_errors no_errors is deleted Sep 26, 2022
lujiashun pushed a commit to lujiashun/stonedb that referenced this issue Sep 26, 2022
feat(StoneDB 8.0): thd->no_errors no_errors is deleted. (stoneatom#574)
e2e063f 
[summary]
1 no_erros is used little in mysql5.7，eg in Item::update_null_value and so on.
2 code is refacted in 8.0,and use push_warning or my_error function to mark errors in is_error function.
@lujiashun lujiashun mentioned this issue Sep 26, 2022
Merged
15 tasks
lujiashun pushed a commit to lujiashun/stonedb that referenced this issue Sep 27, 2022
feat(StoneDB 8.0): thd->no_errors no_errors is deleted. (stoneatom#574)
2fb6f62 
[summary]
1 no_erros is used little in mysql5.7，eg in Item::update_null_value and so on.
2 code is refacted in 8.0,and use push_warning or my_error function to mark errors in is_error function.
mergify bot pushed a commit that referenced this issue Sep 27, 2022
@mergify
feat(StoneDB 8.0): thd->no_errors no_errors is deleted. (#574)
955cacb 
[summary]
1 no_erros is used little in mysql5.7，eg in Item::update_null_value and so on.
2 code is refacted in 8.0,and use push_warning or my_error function to mark errors in is_error function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-feature feature with good idea
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lujiashun