-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(StoneDB 8.0): thd->no_errors no_errors is deleted. (#574) #575
Conversation
Thanks for the contribution! Please review the labels and make any necessary changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see the comment.
[summary] 1 no_erros is used little in mysql5.7,eg in Item::update_null_value and so on. 2 code is refacted in 8.0,and use push_warning or my_error function to mark errors in is_error function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[summary]
1 no_erros is used little in mysql5.7,eg in Item::update_null_value and so on.
2 code is refacted in 8.0,and use push_warning or my_error function to mark errors in is_error function.
Reference: mysql/mysql-server@9fce6b0
in the mysql commit, we can see that is_errors is deleted directly almost. But check the code, like the
the items related function, push_warning|my_error is used to mark errors. So use is_error is a better solution.
Summary about this PR
Issue Number: close #574
fix: thd->no_errors no_errors is deleted.
the no_erros is used little in mysql5.7,eg in Item::update_null_value and so on. In mysql8.0,
the code is refacted,and is used push_warning or my_error function to mark erros in is_error function.
The solution is to use is_erro instead no_errors.
Tests Check List
Changelog
Documentation