Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(StoneDB 8.0): thd->no_errors no_errors is deleted. (#574) #575

Merged
merged 2 commits into from
Sep 27, 2022

Conversation

lujiashun
Copy link

@lujiashun lujiashun commented Sep 26, 2022

[summary]
1 no_erros is used little in mysql5.7,eg in Item::update_null_value and so on.
2 code is refacted in 8.0,and use push_warning or my_error function to mark errors in is_error function.

Reference: mysql/mysql-server@9fce6b0
in the mysql commit, we can see that is_errors is deleted directly almost. But check the code, like the
the items related function, push_warning|my_error is used to mark errors. So use is_error is a better solution.

Summary about this PR

Issue Number: close #574
fix: thd->no_errors no_errors is deleted.
the no_erros is used little in mysql5.7,eg in Item::update_null_value and so on. In mysql8.0,
the code is refacted,and is used push_warning or my_error function to mark erros in is_error function.
The solution is to use is_erro instead no_errors.

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Improvement
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-feature feature for pull request label Sep 26, 2022
Copy link
Contributor

@RingsC RingsC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see the comment.

[summary]
1 no_erros is used little in mysql5.7,eg in Item::update_null_value and so on.
2 code is refacted in 8.0,and use push_warning or my_error function to mark errors in is_error function.
Copy link
Contributor

@RingsC RingsC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@DandreChen DandreChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 955cacb into stoneatom:stonedb-8.0-dev Sep 27, 2022
@lujiashun lujiashun deleted the feat-574 branch September 29, 2022 11:25
@Nliver Nliver added this to the StoneDB_8.0_v1.0.0 milestone Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-feature feature for pull request
Projects
Development

Successfully merging this pull request may close these issues.

4 participants