Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docs some minors in README #1259

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Conversation

amber-moe
Copy link
Contributor

Summary about this PR

Issue Number: close #1254

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@CLAassistant
Copy link

CLAassistant commented Jan 31, 2023

CLA assistant check
All committers have signed the CLA.

@mergify
Copy link
Contributor

mergify bot commented Jan 31, 2023

This pull request's title should follow requirements next. @Amber1990Zhang please check it 👇.

Valid format:

fix(vc): fix sth..... (#3306)
  ^         ^---------^  ^----^
  |         |            |
  |         +            +-> you issue id.
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: feat, fix, docs, workflow, style, refactor, test, website, chore

Valid types:

  • feat: new feature for stonedb
  • fix: bug fix for stonedb
  • docs: changes to the documentation
  • workflow: ci/cd in .github
  • perf: Changes to improve code performance
  • refactor: refactoring production code, eg. renaming a variable
  • style: formatting, missing semi colons, etc; no production code change
  • test: adding missing tests, refactoring tests; no production code change
  • website
  • chore: updating grunt tasks etc; no production code change

@mergify
Copy link
Contributor

mergify bot commented Jan 31, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@amber-moe amber-moe changed the title fix some minors in README fix:docs some minors in README Jan 31, 2023
@mergify mergify bot added the PR-bug bug for pull request label Jan 31, 2023
@hustjieke
Copy link
Collaborator

Thanks for you pr @Amber1990Zhang
PTAL @Nliver

@hustjieke hustjieke requested a review from Nliver January 31, 2023 02:36
@Nliver Nliver requested review from Nliver and removed request for Nliver January 31, 2023 02:37
@Nliver Nliver requested review from RingsC and wisehead January 31, 2023 02:39
@Nliver Nliver added this to the stonedb_5.7_v1.0.3 milestone Jan 31, 2023
@Nliver
Copy link
Collaborator

Nliver commented Jan 31, 2023

Thank you very much for correcting the documentation @Amber1990Zhang.
Of course, I sincerely hope that you can work with us in the future to develop StoneDB Community Edition. You know, writing code is probably more fun than fixing punctuation, right? Come and join us, we are waiting for you ~

Copy link
Collaborator

@Nliver Nliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@hustjieke hustjieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RingsC RingsC changed the title fix:docs some minors in README fix: docs some minors in README Jan 31, 2023
@RingsC RingsC merged commit 7d973b8 into stoneatom:stonedb-5.7-dev Jan 31, 2023
mergify bot pushed a commit that referenced this pull request Feb 27, 2023
konghaiya pushed a commit to konghaiya/stonedb that referenced this pull request Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-bug bug for pull request
Projects
Development

Successfully merging this pull request may close these issues.

docs: typos in README
5 participants