Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stonedb): To support gcc 7.5 or higher and fix up error(#11)(#12) #325

Merged
merged 1 commit into from
Aug 4, 2022
Merged

feat(stonedb): To support gcc 7.5 or higher and fix up error(#11)(#12) #325

merged 1 commit into from
Aug 4, 2022

Conversation

RingsC
Copy link
Contributor

@RingsC RingsC commented Jul 28, 2022

1: To support GCC 7.5 or higher.
2: To fix up some compilation errors.
3: To support -DWITH_ROCKSDB and -DWITH_MARISA to sepcify the directories where rocksdb and marisa installed.

This will also fix issue: #15 to specify the directories of third-party libs.

Issue Number: close #12 and one series of #11

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Improvement
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Jul 28, 2022

This pull request's title is not fulfill the requirements. @RingsC please update it 👇.

Valid format:

fix(vc): fix sth..... (#3306)
  ^         ^---------^  ^----^
  |         |            |
  |         +            +-> you issue id.
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: feat, fix, docs, workflow, style, refactor, test, website, chore

Valid types:

  • feat: new feature for stonedb
  • fix: bug fix for stonedb
  • docs: changes to the documentation
  • workflow: ci/cd in .github
  • refactor: refactoring production code, eg. renaming a variable
  • style: formatting, missing semi colons, etc; no production code change
  • test: adding missing tests, refactoring tests; no production code change
  • website
  • chore: updating grunt tasks etc; no production code change

@mergify
Copy link
Contributor

mergify bot commented Jul 28, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-feature feature for pull request label Jul 28, 2022
@RingsC RingsC marked this pull request as ready for review August 3, 2022 10:59
Copy link
Collaborator

@adofsauron adofsauron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CMakeLists.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@andyli029 andyli029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

1: To support GCC 7.5 or higher.
2: To fix up some compilation errors.
3: To support `-DWITH_ROCKSDB` and `-DWITH_MARISA` to specify the directories
   in which rocksdb and marisa installed.
@mergify mergify bot merged commit 02e57a0 into stoneatom:stonedb-5.6 Aug 4, 2022
@RingsC RingsC deleted the fix-gcc-no-attr-stonedb-5.6 branch August 4, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-feature feature for pull request
Projects
Development

Successfully merging this pull request may close these issues.

4 participants