-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stonedb): To support gcc 7.5 or higher and fix up error(#11)(#12) #325
feat(stonedb): To support gcc 7.5 or higher and fix up error(#11)(#12) #325
Conversation
This pull request's title is not fulfill the requirements. @RingsC please update it 👇. Valid format:
Valid types:
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
1: To support GCC 7.5 or higher.
2: To fix up some compilation errors.
3: To support
-DWITH_ROCKSDB
and-DWITH_MARISA
to sepcify the directories where rocksdb and marisa installed.This will also fix issue: #15 to specify the directories of third-party libs.
Issue Number: close #12 and one series of #11
Tests Check List
Changelog
Documentation