Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(stonedb): To support unspecify the location of 3rd libs(#12). #382

Merged
merged 1 commit into from
Aug 9, 2022
Merged

feat(stonedb): To support unspecify the location of 3rd libs(#12). #382

merged 1 commit into from
Aug 9, 2022

Conversation

RingsC
Copy link
Contributor

@RingsC RingsC commented Aug 9, 2022

If you DO NOT specify the boost, rocksdb and marisa installed path, stonedb will think
these libs were installed at system directories, such as /usr/local, etc. Therefore, now,
stonedb will use these system path as run-path when do compiling.
This is complementary of #325 .

Summary about this PR

Issue Number: close #12

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Improvement
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@RingsC
feat(stonedb): To support unspecify the location of 3rd libs(#12).
d4aaf55 
If you DO NOT specify the boost, rocksdb and marisa installed path, stonedb will think
these libs were installed at system directories, such as `/usr/local`, etc. Therefore, now,
stonedb will use these system path as run-path when do compiling.
@mergify
Copy link
Contributor

mergify bot commented Aug 9, 2022

This pull request's title should follow requirements next. @RingsC please check it 👇.

Valid format:

fix(vc): fix sth..... (#3306)
  ^         ^---------^  ^----^
  |         |            |
  |         +            +-> you issue id.
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: feat, fix, docs, workflow, style, refactor, test, website, chore

Valid types:

  • feat: new feature for stonedb
  • fix: bug fix for stonedb
  • docs: changes to the documentation
  • workflow: ci/cd in .github
  • refactor: refactoring production code, eg. renaming a variable
  • style: formatting, missing semi colons, etc; no production code change
  • test: adding missing tests, refactoring tests; no production code change
  • website
  • chore: updating grunt tasks etc; no production code change

@mergify
Copy link
Contributor

mergify bot commented Aug 9, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-feature feature for pull request label Aug 9, 2022
@RingsC RingsC marked this pull request as ready for review August 9, 2022 05:33
adofsauron
adofsauron approved these changes Aug 9, 2022
View reviewed changes
Copy link
Collaborator

@adofsauron adofsauron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hustjieke
hustjieke approved these changes Aug 9, 2022
View reviewed changes
Copy link
Collaborator

@hustjieke hustjieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mergify mergify bot merged commit e0a23ce into stoneatom:stonedb-5.6 Aug 9, 2022
@RingsC RingsC deleted the fix-cmake-stonedb-un-specify-path branch August 9, 2022 11:58
andyli029
andyli029 approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@andyli029 andyli029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Nliver Nliver added this to the StoneDB_5.7_v1.0.0 milestone Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adofsauron adofsauron adofsauron approved these changes

@andyli029 andyli029 andyli029 approved these changes

@hustjieke hustjieke hustjieke approved these changes

Assignees

@RingsC RingsC

Labels
PR-feature feature for pull request
Projects
StoneDB for MySQL 5.7
Status: Done
Milestone
StoneDB_5.7_v1.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@RingsC @adofsauron @andyli029 @hustjieke @Nliver