Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rulesets): __importDefault undefined #2243

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented Aug 15, 2022

Fixes #2240

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

@P0lip P0lip added the t/bug Something isn't working label Aug 15, 2022
@P0lip P0lip self-assigned this Aug 15, 2022
@P0lip P0lip requested a review from a team as a code owner August 15, 2022 08:49
Comment on lines +1 to +3
import { default as uniquenessTags } from './uniquenessTags';

export { uniquenessTags };
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this results in a slightly smaller output, as no __importDefault function is declared

@@ -44,7 +44,7 @@
"declaration": true,
"removeComments": true,
"skipLibCheck": true,
"noEmitHelpers": true,
"noEmitHelpers": false,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but in case someone does want to use export { default as xyz }, we're now covered and the function will be output.

@P0lip P0lip merged commit 660f090 into develop Aug 15, 2022
@P0lip P0lip deleted the fix/rulesets/import-default branch August 15, 2022 08:54
stoplight-bot pushed a commit that referenced this pull request Aug 15, 2022
@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version @stoplight/spectral-rulesets-v1.11.2 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released t/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue importing oas ruleset from @stoplight/spectral-rulesets
2 participants