Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update access/delegate spec to use nb: {delegations: Dict<string,Link>} instead of nb: Dict<string,Link> #45

Closed
Tracked by #393
gobengo opened this issue Feb 1, 2023 · 2 comments · Fixed by #47
Closed
Tracked by #393

update access/delegate spec to use nb: {delegations: Dict<string,Link>} instead of nb: Dict<string,Link> #45

gobengo opened this issue Feb 1, 2023 · 2 comments · Fixed by #47
Assignees
@gobengo
Milestone
w3up phase 2

Comments

@gobengo
Copy link
Contributor

gobengo commented Feb 1, 2023

because the former is easier to type using ucanto atm. nb doesn't take a schema, so can't use Schema.dictionary() on it
@gobengo gobengo self-assigned this Feb 1, 2023
@gobengo gobengo changed the title update access/authorize spec to use nb.delegations: Dict<string,Link> instead of nb: Dict<string,Link> update access/authorize spec to use nb: {delegations: Dict<string,Link>} instead of nb: Dict<string,Link> Feb 1, 2023
@hugomrdias
Copy link
Contributor

its access/delegate right ?

@gobengo
Copy link
Contributor Author

gobengo commented Feb 1, 2023

@hugomrdias Yes, thank you!

@gobengo gobengo changed the title update access/authorize spec to use nb: {delegations: Dict<string,Link>} instead of nb: Dict<string,Link> update access/delegate spec to use nb: {delegations: Dict<string,Link>} instead of nb: Dict<string,Link> Feb 1, 2023
This was referenced Feb 1, 2023
Merged
Closed
@gobengo gobengo linked a pull request Feb 1, 2023 that will close this issue
feat!: access/delegate delegation set is at nb.delegations instead of nb root #47
Merged
@gobengo gobengo added this to the w3up phase 2 milestone Feb 1, 2023
@Gozala Gozala closed this as completed in #47 Feb 1, 2023
Gozala pushed a commit that referenced this issue Feb 1, 2023
@gobengo
feat!: access/delegate delegation set is at nb.delegations instead of…
7e662a2 
… nb root (#47)

Motivation:
* #45

Note:
* this is backward incompatible, but afaict this protocol is
pre-implementation, so I think that should be ok
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gobengo gobengo

Labels
None yet
Projects
None yet
Milestone
w3up phase 2
Development

Successfully merging a pull request may close this issue.

feat!: access/delegate delegation set is at nb.delegations instead of nb root storacha/specs
2 participants
@gobengo @hugomrdias