Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement access/delegate in access-api #393

Closed
7 tasks done
Tracked by #220
, #7
...
alanshaw opened this issue Jan 25, 2023 · 5 comments
Closed
7 tasks done
Tracked by #220
, #7
...

Implement access/delegate in access-api #393

alanshaw opened this issue Jan 25, 2023 · 5 comments
Assignees
@Gozala @gobengo
Milestone
w3up phase 3

Comments

@alanshaw
Copy link
Member

alanshaw commented Jan 25, 2023 •
edited by gobengo
Loading

https://github.com/web3-storage/specs/blob/main/w3-access.md#accessdelegate
@alanshaw alanshaw added this to the w3up phase 2 milestone Jan 25, 2023
@alanshaw alanshaw mentioned this issue Jan 25, 2023
Closed
95 tasks
This was referenced Jan 31, 2023
Closed
Closed
Closed
Closed
@gobengo
Copy link
Contributor

gobengo commented Feb 6, 2023

#status need review on #420

@heyjay44 heyjay44 mentioned this issue Feb 9, 2023
Closed
83 tasks
@heyjay44 heyjay44 modified the milestones: w3up phase 2, w3up phase 3 Feb 9, 2023
@gobengo gobengo assigned Gozala and unassigned hugomrdias Feb 20, 2023
@gobengo
Copy link
Contributor

gobengo commented Feb 20, 2023 •
edited
Loading

@alanshaw fyi I just updated the OP link to the spec from a feat/ branch to the main branch link

old: https://github.com/web3-storage/specs/blob/feat/w3-authorization/w3-access.md#accessdelegate
new: https://github.com/web3-storage/specs/blob/main/w3-access.md#accessdelegate

lmk if that was a bad idea

@gobengo
Copy link
Contributor

gobengo commented Feb 20, 2023 •
edited
Loading

#status see #425 (comment)

@gobengo
Copy link
Contributor

gobengo commented Feb 28, 2023

#status I can't show off access/delegate working e2e until we have a way of registering a space, which we're implementing as #459

This was referenced Mar 1, 2023
Closed
Closed
Merged
gobengo added a commit that referenced this issue Mar 7, 2023
@gobengo
fix: access/delegate checks hasStorageProvider(space) in a way that p…
f4c640d 
…rovider/add allows access/delegate (#483)

Motivation:
* #393
*
[discovered](https://filecoinproject.slack.com/archives/C02BZPRS9HP/p1678146419356999?thread_ts=1678146205.801039&cid=C02BZPRS9HP)
while testing https://observablehq.com/d/95bfec64fbb3c2d1@421

This makes it so that `access/delegate` will detect that a storage
provider has been registered with a space via `provider/add`. Previously
it would only allow spaces who had completed a `voucher/redeem` flow.
Now it will support both. In the long run we will disable the
`voucher/redeem` part.
@gobengo
Copy link
Contributor

gobengo commented Mar 20, 2023

this is done in access-api trunk, and @web3-storage/access (access-client) makes use of it as of #395

@gobengo gobengo closed this as completed Mar 20, 2023
gobengo added a commit that referenced this issue Apr 11, 2023
@gobengo
fix: access/delegate checks hasStorageProvider(space) in a way that p…
1d3d562 
…rovider/add allows access/delegate (#483)

Motivation:
* #393
*
[discovered](https://filecoinproject.slack.com/archives/C02BZPRS9HP/p1678146419356999?thread_ts=1678146205.801039&cid=C02BZPRS9HP)
while testing https://observablehq.com/d/95bfec64fbb3c2d1@421

This makes it so that `access/delegate` will detect that a storage
provider has been registered with a space via `provider/add`. Previously
it would only allow spaces who had completed a `voucher/redeem` flow.
Now it will support both. In the long run we will disable the
`voucher/redeem` part.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gozala Gozala

@gobengo gobengo

Labels
None yet
Projects
None yet
Milestone
w3up phase 3
Development

No branches or pull requests
5 participants
@Gozala @alanshaw @gobengo @hugomrdias @heyjay44