Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back port peer dependency fixes to 5.x? #10425

Closed
voxpelli opened this issue Apr 14, 2020 · 4 comments
Closed

Back port peer dependency fixes to 5.x? #10425

voxpelli opened this issue Apr 14, 2020 · 4 comments

Comments

@voxpelli
Copy link

voxpelli commented Apr 14, 2020

Is your feature request related to a problem? Please describe.
Installing complains of lots of different missing peer dependencies + apparently it doesn't work at all in Yarn 2 (see #9667, #9916 and #9965 )

Describe the solution you'd like
Backport the fix in #9667, #9916, #9965 and maybe others of the same to 5.x

Describe alternatives you've considered
I guess it works kind of as it is now in 5.x, unless one uses Yarn 2, but it becomes rather noisy at times, with risks of causing some alert fatigue around missing peer dependencies

Are you able to assist bring the feature to reality?
Maybe I can find time to help cherry-pick the relevant changes into a PR if there's interest.

Related: #2303, #7625, #7989

@shilman
Copy link
Member

shilman commented Apr 15, 2020

I'd rather focus on getting 6.0 out the door. After some time-consuming destabilizing patches-gone-wrong early in the 5.3.x cycle, I'd like to reserve patching to critical bugs.

@voxpelli
Copy link
Author

@shilman That sounds totally reasonable. Where can one track what work remains for 6.x to move to beta/rc so that one could start trying that one in live projects?

@shilman
Copy link
Member

shilman commented Apr 16, 2020

There are a number of milestones with active issues for each major 6.0 feature

https://github.com/storybookjs/storybook/milestones

This issue tracks estimates, tho it’s slipping

#9311

@stale
Copy link

stale bot commented May 7, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants