Add missing dependencies or peerDependencies #9916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`regenerator-runtime` is used as polyfill to backport async/await and generator to old browser (like core-js). Any package that use async/await or generator will require `regenerator-runtime` at runtime without any import in the source (it's added by babel during transpilation). To avoid any issue in the future `regenerator-runtime` is added to almost all packages, as it has been done for `core-js` What I did? - Add it when it was missing - Move it from peerDep to dep when needed - Use the same, and latest, version for all packages
gaetanmaisse
added
dependencies
maintenance
gaetanmaisse
force-pushed
the
fix-deps
branch
from
845a6f4
to
f69396b
Compare
ndelangen
approved these changes
Feb 20, 2020
gaetanmaisse
requested review from
alexandrebodin,
alterx,
CodeByAlex,
dangreenisrael,
igor-dv,
jbovenschen,
kazupon,
leonrodenburg,
thani-sh,
renaudtertrais,
saponifi3d,
theinterned,
thomasbertet,
tmeasday,
usulpro and
z4o4z
as code owners
|
Then, why |
|
@JalilArfaoui Where do you see that dependency still specified as a peerDependency? |
|
I’m sorry @ndelangen ! I had an out-of-date @storybook/api in my modules, and I felt upon this PR and thought it was still like this ! You can close this, sorry for the inconvenience |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
As Yarn 2 is must stricter than Yarn 1 or NPM about missing
dependenciesorpeerDependenciesI usednpx @yarnpkg/doctor(details here) to fix some of them.There are still a lot more, I will fix them step by step.
--
Specific case of
regenerator-runtime: as discussed with @ndelangenregenerator-runtimeis used as polyfill to backport async/await and generator to old browser (like core-js). Any package that uses async/await or generator will requireregenerator-runtimeat runtime without any import in the source (it's added by babel during transpilation). To avoid any issue in the futureregenerator-runtimeis added to almost all packages, as it has been done forcore-jsHow to test