Misc: Add missing dependencies #9965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaetanmaisse
force-pushed
the
add-missing-deps
branch
2 times, most recently
from
dfdb7cc
to
85d8f7b
Compare
|
As storybook/lib/router/package.json Line 42 in dac6752 |
gaetanmaisse
force-pushed
the
add-missing-deps
branch
from
85d8f7b
to
df7ea83
Compare
Used `npx @yarnpkg/doctor .` to have the list of all missing deps. Added them with version range already used in the workspace to avoid downloading new dep (that's why yarn.lock is not modified)
Used `npx @yarnpkg/doctor .` to have the list of all missing deps. Added them with version range already used in the workspace to avoid downloading new dep (that's why yarn.lock is not modified)
gaetanmaisse
force-pushed
the
add-missing-deps
branch
from
df7ea83
to
81e8e67
Compare
gaetanmaisse
requested review from
igor-dv,
ndelangen,
theinterned and
tmeasday
as code owners
ndelangen
approved these changes
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #9916
What I did
As Yarn 2 is much stricter than Yarn 1 or NPM about missing
dependenciesorpeerDependenciesI usednpx @yarnpkg/doctor(details here) to fix some of them. Added them with version range already used in the workspace to avoid downloading new deps (that's why yarn.lock is not modified)