Misc: Add some missing dependencies #10012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robula
requested review from
aaronmcadam,
ndelangen,
shilman,
stijnkoopal and
theinterned
as code owners
gaetanmaisse
requested changes
Mar 5, 2020
|
@Robula I added a few comments, let me know if you have any question! |
|
@gaetanmaisse Thank you for your comments, I have made the requested changes. 👼 |
gaetanmaisse
approved these changes
Mar 9, 2020
|
@Robula LGTM. Can you squash your 3 commits into a single one and force push to avoid polluting git history with irrelevant changes? Then tag me and I will merge this PR 💻 |
|
@gaetanmaisse All done 🎉 |
gaetanmaisse
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
@storybook/cli@npm:6.0.0-alpha.20 doesn't provide jest@* requested by @storybook/codemod@npm:6.0.0-alpha.20@storybook/codemod@npm:6.0.0-alpha.20 doesn't provide jest@* requested by jest-specific-snapshot@npm:2.0.0What I did
Added the missing peerDependencies to their relevant package.