Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Update deprecated transitive dependencies of magic-string and jscodeshift #20822

Closed
stevezhu opened this issue Jan 29, 2023 · 2 comments · Fixed by #20925
Closed

[Bug]: Update deprecated transitive dependencies of magic-string and jscodeshift #20822

stevezhu opened this issue Jan 29, 2023 · 2 comments · Fixed by #20925

Comments

@stevezhu
Copy link

stevezhu commented Jan 29, 2023

Describe the bug

A few transitive dependencies of magic-string and jscodeshift are deprecated. Updates needed to these two packages below.

Updates needed

Deprecation warnings

 WARN  deprecated sourcemap-codec@1.4.8: Please use @jridgewell/sourcemap-codec instead
 WARN  deprecated source-map-resolve@0.5.3: See https://github.com/lydell/source-map-resolve#deprecated
 WARN  deprecated source-map-url@0.4.1: See https://github.com/lydell/source-map-url#deprecated
 WARN  deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
 WARN  deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated

To Reproduce

No response

System

System:
    OS: macOS 13.1
    CPU: (8) x64 Intel(R) Core(TM) i5-1038NG7 CPU @ 2.00GHz
  Binaries:
    Node: 19.5.0 - /usr/local/bin/node
    npm: 9.3.1 - /usr/local/bin/npm
  Browsers:
    Chrome: 109.0.5414.119
    Firefox: 90.0.2
    Safari: 16.2

Additional context

Dependency tree:

@storybook/react-vite 7.0.0-beta.36
├─┬ @storybook/builder-vite 7.0.0-beta.36
│ └─┬ magic-string 0.26.7
│   └── sourcemap-codec 1.4.8
└─┬ magic-string 0.26.7
  └── sourcemap-codec 1.4.8
storybook 7.0.0-beta.36
└─┬ @storybook/cli 7.0.0-beta.36
  ├─┬ @storybook/codemod 7.0.0-beta.36
  │ └─┬ jscodeshift 0.13.1
  │   └─┬ micromatch 3.1.10
  │     ├─┬ braces 2.3.2
  │     │ └─┬ snapdragon 0.8.2
  │     │   └─┬ source-map-resolve 0.5.3
  │     │     ├── resolve-url 0.2.1
  │     │     ├── source-map-url 0.4.1
  │     │     └── urix 0.1.0
  │     ├─┬ extglob 2.0.4
  │     │ ├─┬ expand-brackets 2.1.4
  │     │ │ └─┬ snapdragon 0.8.2
  │     │ │   └─┬ source-map-resolve 0.5.3
  │     │ │     ├── resolve-url 0.2.1
  │     │ │     ├── source-map-url 0.4.1
  │     │ │     └── urix 0.1.0
  │     │ └─┬ snapdragon 0.8.2
  │     │   └─┬ source-map-resolve 0.5.3
  │     │     ├── resolve-url 0.2.1
  │     │     ├── source-map-url 0.4.1
  │     │     └── urix 0.1.0
  │     ├─┬ nanomatch 1.2.13
  │     │ └─┬ snapdragon 0.8.2
  │     │   └─┬ source-map-resolve 0.5.3
  │     │     ├── resolve-url 0.2.1
  │     │     ├── source-map-url 0.4.1
  │     │     └── urix 0.1.0
  │     └─┬ snapdragon 0.8.2
  │       └─┬ source-map-resolve 0.5.3
  │         ├── resolve-url 0.2.1
  │         ├── source-map-url 0.4.1
  │         └── urix 0.1.0
  └─┬ jscodeshift 0.13.1
    └─┬ micromatch 3.1.10
      ├─┬ braces 2.3.2
      │ └─┬ snapdragon 0.8.2
      │   └─┬ source-map-resolve 0.5.3
      │     ├── resolve-url 0.2.1
      │     ├── source-map-url 0.4.1
      │     └── urix 0.1.0
      ├─┬ extglob 2.0.4
      │ ├─┬ expand-brackets 2.1.4
      │ │ └─┬ snapdragon 0.8.2
      │ │   └─┬ source-map-resolve 0.5.3
      │ │     ├── resolve-url 0.2.1
      │ │     ├── source-map-url 0.4.1
      │ │     └── urix 0.1.0
      │ └─┬ snapdragon 0.8.2
      │   └─┬ source-map-resolve 0.5.3
      │     ├── resolve-url 0.2.1
      │     ├── source-map-url 0.4.1
      │     └── urix 0.1.0
      ├─┬ nanomatch 1.2.13
      │ └─┬ snapdragon 0.8.2
      │   └─┬ source-map-resolve 0.5.3
      │     ├── resolve-url 0.2.1
      │     ├── source-map-url 0.4.1
      │     └── urix 0.1.0
      └─┬ snapdragon 0.8.2
        └─┬ source-map-resolve 0.5.3
          ├── resolve-url 0.2.1
          ├── source-map-url 0.4.1
          └── urix 0.1.0
@stevezhu
Copy link
Author

magic-string updated to v0.27.0: #20839

programmarchy added a commit to programmarchy/storybook that referenced this issue Feb 3, 2023
Fixes deprecated warning described in storybookjs#20822
programmarchy added a commit to programmarchy/storybook that referenced this issue Feb 3, 2023
Fixes deprecated warning described in storybookjs#20822
@shilman
Copy link
Member

shilman commented Feb 4, 2023

Yo-ho-ho!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.0-beta.42 containing PR #20925 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb@next upgrade --prerelease

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants