Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deps: Upgrade magic-string to 0.27.0 #20839

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Deps: Upgrade magic-string to 0.27.0 #20839

merged 1 commit into from
Jan 30, 2023

Conversation

Dschungelabenteuer
Copy link
Member

@Dschungelabenteuer Dschungelabenteuer commented Jan 30, 2023

Following #20698, some users reported an error thrown around Magic String's update method.

What I did

It turns out the update method was introduced in version 0.26.6, but Storybook packages actually set it to ^0.26.1.

I've opted for 0.27.0 instead of 0.26.6 because it does not seem to have any breaking changes and we could benefit from performance improvements they made.

How to test

This should be pretty straight-forward. I think the issue does not occur on clean installs because it should already pick magic-string's latest patch. Let's see if CI passes!

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

Copy link
Member

@IanVS IanVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@socket-security
Copy link

Socket Security Pull Request Report

Dependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again.

⚠️ Uses eval

Package uses eval() which is a dangerous function. This prevents the code from running in certain environments and increases the risk that the code may contain exploits or malicious behavior.

Avoid packages that use eval, since this could potentially execute any code.

Package Eval Type Location Source
terser@5.16.2 (added) eval dist/bundle.min.js scripts/package.json via babel-loader@9.1.2, ts-loader@9.4.2, test-storybooks/ember-cli/package.json via @storybook/ember@7.0.0-alpha.43, babel-loader@8.3.0, webpack@5.75.0, webpack-cli@4.10.0, test-storybooks/external-docs/package.json via @storybook/react-webpack5@7.0.0-alpha.43, nextra@1.1.0, nextra-theme-docs@1.2.6, webpack@5.75.0, test-storybooks/server-kitchen-sink/package.json via @storybook/server-webpack5@7.0.0-alpha.43, test-storybooks/standalone-preview/package.json via @storybook/react-webpack5@7.0.0-alpha.43, parcel@2.0.1
vite@4.0.4 (added) eval dist/node/chunks/dep-5e7f419b.js code/package.json via @storybook/builder-vite@0.3.0, code/frameworks/html-vite/package.json via @storybook/builder-vite@7.0.0-beta.36, code/frameworks/preact-vite/package.json via @preact/preset-vite@2.5.0, @storybook/builder-vite@7.0.0-beta.36, code/frameworks/react-vite/package.json via @joshwooding/vite-plugin-react-docgen-typescript@0.2.1, @storybook/builder-vite@7.0.0-beta.36, @vitejs/plugin-react@3.0.1, code/frameworks/svelte-vite/package.json via @storybook/builder-vite@7.0.0-beta.36, @sveltejs/vite-plugin-svelte@2.0.2, code/frameworks/sveltekit/package.json via @storybook/builder-vite@7.0.0-beta.36, @storybook/svelte-vite@7.0.0-beta.36, code/frameworks/vue-vite/package.json via @storybook/builder-vite@7.0.0-beta.36, code/frameworks/vue3-vite/package.json via @storybook/builder-vite@7.0.0-beta.36, @vitejs/plugin-vue@4.0.0, code/frameworks/web-components-vite/package.json via @storybook/builder-vite@7.0.0-beta.36, code/lib/builder-vite/package.json via @preact/preset-vite@2.5.0
vite@4.0.4 (added) eval dist/node/chunks/dep-5e7f419b.js code/package.json via @storybook/builder-vite@0.3.0, code/frameworks/html-vite/package.json via @storybook/builder-vite@7.0.0-beta.36, code/frameworks/preact-vite/package.json via @preact/preset-vite@2.5.0, @storybook/builder-vite@7.0.0-beta.36, code/frameworks/react-vite/package.json via @joshwooding/vite-plugin-react-docgen-typescript@0.2.1, @storybook/builder-vite@7.0.0-beta.36, @vitejs/plugin-react@3.0.1, code/frameworks/svelte-vite/package.json via @storybook/builder-vite@7.0.0-beta.36, @sveltejs/vite-plugin-svelte@2.0.2, code/frameworks/sveltekit/package.json via @storybook/builder-vite@7.0.0-beta.36, @storybook/svelte-vite@7.0.0-beta.36, code/frameworks/vue-vite/package.json via @storybook/builder-vite@7.0.0-beta.36, code/frameworks/vue3-vite/package.json via @storybook/builder-vite@7.0.0-beta.36, @vitejs/plugin-vue@4.0.0, code/frameworks/web-components-vite/package.json via @storybook/builder-vite@7.0.0-beta.36, code/lib/builder-vite/package.json via @preact/preset-vite@2.5.0
vite@4.0.4 (added) eval dist/node/chunks/dep-5e7f419b.js code/package.json via @storybook/builder-vite@0.3.0, code/frameworks/html-vite/package.json via @storybook/builder-vite@7.0.0-beta.36, code/frameworks/preact-vite/package.json via @preact/preset-vite@2.5.0, @storybook/builder-vite@7.0.0-beta.36, code/frameworks/react-vite/package.json via @joshwooding/vite-plugin-react-docgen-typescript@0.2.1, @storybook/builder-vite@7.0.0-beta.36, @vitejs/plugin-react@3.0.1, code/frameworks/svelte-vite/package.json via @storybook/builder-vite@7.0.0-beta.36, @sveltejs/vite-plugin-svelte@2.0.2, code/frameworks/sveltekit/package.json via @storybook/builder-vite@7.0.0-beta.36, @storybook/svelte-vite@7.0.0-beta.36, code/frameworks/vue-vite/package.json via @storybook/builder-vite@7.0.0-beta.36, code/frameworks/vue3-vite/package.json via @storybook/builder-vite@7.0.0-beta.36, @vitejs/plugin-vue@4.0.0, code/frameworks/web-components-vite/package.json via @storybook/builder-vite@7.0.0-beta.36, code/lib/builder-vite/package.json via @preact/preset-vite@2.5.0
workerpool@3.1.2 (added) eval dist/workerpool.js code/package.json via @storybook/ember@6.5.16, code/frameworks/ember/package.json via @types/ember__component@4.0.8, ember-source@3.28.11, test-storybooks/ember-cli/package.json via @storybook/ember@7.0.0-alpha.43, @storybook/ember-cli-storybook@0.2.1, ember-ajax@5.1.2, ember-cli@3.24.0, ember-cli-app-version@4.0.0, ember-cli-babel@7.26.11, ember-load-initializers@2.1.2, ember-named-blocks-polyfill@0.2.5, ember-resolver@7.0.0, ember-source@3.24.7
workerpool@3.1.2 (added) eval dist/workerpool.min.js code/package.json via @storybook/ember@6.5.16, code/frameworks/ember/package.json via @types/ember__component@4.0.8, ember-source@3.28.11, test-storybooks/ember-cli/package.json via @storybook/ember@7.0.0-alpha.43, @storybook/ember-cli-storybook@0.2.1, ember-ajax@5.1.2, ember-cli@3.24.0, ember-cli-app-version@4.0.0, ember-cli-babel@7.26.11, ember-load-initializers@2.1.2, ember-named-blocks-polyfill@0.2.5, ember-resolver@7.0.0, ember-source@3.24.7
workerpool@3.1.2 (added) eval lib/worker.js code/package.json via @storybook/ember@6.5.16, code/frameworks/ember/package.json via @types/ember__component@4.0.8, ember-source@3.28.11, test-storybooks/ember-cli/package.json via @storybook/ember@7.0.0-alpha.43, @storybook/ember-cli-storybook@0.2.1, ember-ajax@5.1.2, ember-cli@3.24.0, ember-cli-app-version@4.0.0, ember-cli-babel@7.26.11, ember-load-initializers@2.1.2, ember-named-blocks-polyfill@0.2.5, ember-resolver@7.0.0, ember-source@3.24.7
Pull request report summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Shell access ✅ 0 issues
Uses eval ⚠️ 7 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
GitHub dependency ✅ 0 issues
New author ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
AI detected malware ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@2.4.2

  • @SocketSecurity ignore terser@5.16.2
  • @SocketSecurity ignore vite@4.0.4
  • @SocketSecurity ignore workerpool@3.1.2

Powered by socket.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants