CLI: Update mithril/rax/web-components templates, rework Yarn2 e2e #11354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaetanmaisse
force-pushed
the
add-yarn-2-e2e-tests
branch
from
731f2ba
to
bae2cbc
Compare
gaetanmaisse
force-pushed
the
add-yarn-2-e2e-tests
branch
2 times, most recently
from
8d3f2c8
to
c2d6cc7
Compare
gaetanmaisse
changed the title
gaetanmaisse
force-pushed
the
add-yarn-2-e2e-tests
branch
2 times, most recently
from
0560e86
to
2c4ca1c
Compare
|
Templates for |
gaetanmaisse
requested review from
igor-dv,
ndelangen,
shilman and
stijnkoopal
as code owners
gaetanmaisse
force-pushed
the
add-yarn-2-e2e-tests
branch
2 times, most recently
from
a02248e
to
c03072a
Compare
|
I updated mithril and web component stories. And everything is 🟢 🎉 @shilman @ndelangen 🎆
|
gaetanmaisse
changed the title
Using `latest` keyword with yarn 1 resolves to Yarn 1.x but we need Yarn 2.
Example stories for riot need to be updated. Moreover, they should be migrated to riot@4.
…@storybook/cli package
It was previously `{{name}}-v{{version}}` but the `v` isn't needed as we are using `latest` version in many and `vX-lts` for angular.
gaetanmaisse
force-pushed
the
add-yarn-2-e2e-tests
branch
from
c03072a
to
a8090fb
Compare
yannbf
reviewed
Jul 27, 2020
| @@ -92,7 +116,12 @@ const initStorybook = async ({ cwd, autoDetect = true, name }: Options) => { | |||
| logger.info(`🎨 Initializing Storybook with @storybook/cli`); | |||
| try { | |||
| const type = autoDetect ? '' : `--type ${name}`; | |||
| await exec(`npx -p @storybook/cli sb init --yes ${type}`, { cwd }); | |||
|
|
|||
| const sbCLICommand = useLocalSbCli | |||
There was a problem hiding this comment.
yannbf
reviewed
Jul 27, 2020
| version: '3', | ||
| generator: fromDeps('riot@3', 'riot-compiler@3', 'riot-tmpl@3'), | ||
| }; | ||
| // export const riot: Parameters = { |
There was a problem hiding this comment.
We really need to come back to these frameworks :s
shilman
changed the title
shilman
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #10797
What I did
E2E:
--use-yarn-2flag to run tests with Yarn 2--use-local-sb-cliflag to run E2E tests with local@storybook/clipackagedocument.createElement(...)or plain text i.e."<div></div>")CLI:
How to test
examples-v2-yarn-2job