Addon-knobs: Move @types/react-color to devDeps
#11690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iles All theses functions shouldn't be used outside the class, making them private simplify the types generated in type definition files (`.d.ts`). This enable us to move some deps to devDeps if they are not used (imported) in generated definition files.
No definition file is using it anymore so we can move this regular dep to devDeps.
gaetanmaisse
requested review from
alexandrebodin,
alterx,
leonrodenburg and
theinterned
as code owners
shilman
changed the title
@typesreact-color to devDeps@types/react-color to devDeps
shilman
changed the title
@types/react-color to devDeps@types/react-color to devDeps
shilman
approved these changes
Jul 26, 2020
There was a problem hiding this comment.
LGTM! Do we need to do something similar for Controls? It uses similar patterns @gaetanmaisse
This was referenced Nov 17, 2020
This was referenced Nov 18, 2020
This was referenced Jun 23, 2023
This was referenced Nov 30, 2023
This was referenced Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #11315
What I did
See #11315 (comment)
TLDR;
It looks like some function of components from
addon-knob(handleChangeandhandleClick) should be private functions as they are used to handle internal stuff. Making then private leads to a generatedColor.d.tsthat doesn't import things from@types/react-coloranymore so we can move this dependency from regular dep to devDep 🎉 .How to test
addon-knobsshould compileexample-v2, but for other reasons: CLI: Update mithril/rax/web-components templates, rework Yarn2 e2e #11354 fixes that)