Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Upgrade Cypress and Node.js version used in e2e tests #16263

Merged
merged 12 commits into from
Oct 27, 2021

Conversation

gaetanmaisse
Copy link
Member

@gaetanmaisse gaetanmaisse commented Oct 6, 2021

Issue: #16254

What I did

To investigate the issue I used:

yarn local-registry --port 6000 --open --publish
# And in another terminal
yarn test:e2e-framework vue3 --clean --use-local-sb-cli

With Node.js v12.20.1 everything was working, however with v12.18.4 is was throwing:

ERR! Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './dist/vue.esm-bundler.js' is not defined by "exports" in /tmp/storybook-e2e-testing/vue3/node_modules/vue/package.json
ERR!     at applyExports (internal/modules/cjs/loader.js:490:9)
ERR!     at resolveExports (internal/modules/cjs/loader.js:506:23)
ERR!     at Function.Module._findPath (internal/modules/cjs/loader.js:634:31)
ERR!     at Function.Module._resolveFilename (internal/modules/cjs/loader.js:952:27)
ERR!     at Function.resolve (internal/modules/cjs/helpers.js:78:19)
ERR!     at Object.webpack (/tmp/storybook-e2e-testing/vue3/node_modules/@storybook/vue3/dist/cjs/server/framework-preset-vue3.js:43:23)
ERR!     at /tmp/storybook-e2e-testing/vue3/node_modules/@storybook/core-common/dist/cjs/presets.js:274:28
ERR!     at async Object.build (/tmp/storybook-e2e-testing/vue3/node_modules/@storybook/builder-webpack4/dist/cjs/index.js:174:16)
ERR!     at async Promise.all (index 1)
ERR!     at async buildStaticStandalone (/tmp/storybook-e2e-testing/vue3/node_modules/@storybook/core-server/dist/cjs/build-static.js:149:28)
ERR!     at async buildStatic (/tmp/storybook-e2e-testing/vue3/node_modules/@storybook/core-server/dist/cjs/build-static.js:169:5)

Digging a bit in the Node.js release note I found:

(SEMVER-MINOR) exports pattern support (Guy Bedford) nodejs/node#34718

Which is definitely related to the issue.

As the Docker image used in E2E tests is provided by Cypress and based on a specific version of Node.js I decided to update Cypress and so the version of Node.js used in the E2E tests.

--

I also fixed the path of the preset file of @storybook/vue

How to test

  • E2E CI jobs should back to 🟢 !

@nx-cloud
Copy link

nx-cloud bot commented Oct 6, 2021

Nx Cloud Report

CI ran the following commands for commit 4672912. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@gaetanmaisse gaetanmaisse added the maintenance User-facing maintenance tasks label Oct 6, 2021
@gaetanmaisse gaetanmaisse force-pushed the update-cypress-and-node branch 3 times, most recently from 15da677 to 02e4462 Compare October 7, 2021 06:28
@gaetanmaisse gaetanmaisse marked this pull request as ready for review October 26, 2021 20:22
@gaetanmaisse
Copy link
Member Author

🎉 All green @shilman!

@shilman
Copy link
Member

shilman commented Oct 27, 2021

You are the best @gaetanmaisse!!! 🙌 🙌 🙌

@shilman shilman changed the title CI: Upgrade Cypress and so Node.js version used in e2e tests CI: Upgrade Cypress and Node.js version used in e2e tests Oct 27, 2021
@shilman shilman merged commit eff5efe into next Oct 27, 2021
@shilman shilman deleted the update-cypress-and-node branch October 27, 2021 15:17
@shilman shilman added this to the 6.4 PRs milestone Oct 27, 2021
@shilman shilman mentioned this pull request Oct 27, 2021
@yannbf
Copy link
Member

yannbf commented Oct 27, 2021

You are indeed the best @gaetanmaisse!!! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants