Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to skip cypress tests based on framework #16285

Merged
merged 1 commit into from
Oct 8, 2021

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Oct 8, 2021

Issue: N/A

What I did

This PR adds a way to skip certain specs based on frameworks, such as skipping dynamic rendering spec on vue3, which does not have dynamic rendering.

The command uses name which is defined in here like this.

How to test

  • Clone the repo

  • Install the deps

  • Spin up verdaccio: yarn local-registry --port 6000 --open --publish

  • On another terminal, run yarn test:e2e-framework and select vue3

  • Select addon-docs spec

  • It should skip vue3, but should run for other frameworks

  • Is this testable with Jest or Chromatic screenshots?

  • Does this need a new example in the kitchen sink apps?

  • Does this need an update to the documentation? As a followup, we should have an "E2E testing" improvement story so we can iron out some frustrations when running stuff locally + add some guidance docs.

If your answer is yes to any of these, please make sure to include it in your PR.

@yannbf yannbf added the maintenance User-facing maintenance tasks label Oct 8, 2021
@nx-cloud
Copy link

nx-cloud bot commented Oct 8, 2021

Nx Cloud Report

CI ran the following commands for commit 1d051d6. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great @yannbf 🙌

@yannbf
Copy link
Member Author

yannbf commented Oct 8, 2021

btw the only failing step in CI is happening because of issues installing stuff in the vue3 repro, it's not related to this PR.
@gaetanmaisse I heard you're working on fixing that? If you'd like assistance let me know!

@gaetanmaisse
Copy link
Member

True @yannbf in #16263 I added my current investigation and some context in the description, I think I now need to update the cypress tests to make them work after the 6 -> 8 upgrade.

@shilman shilman merged commit 0bb0cdc into next Oct 8, 2021
@shilman shilman deleted the feature/cypress-skip-tests branch October 8, 2021 14:48
@shilman shilman added this to the 6.4 PRs milestone Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants