Upgrade file-system-cache to 2.0.0 and remove custom types #18253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are using @storybook/core-common in our project and it pulls file-system@1.0.5 --> ramda@0.21.0. We need to use ramda@0.28.0 which file-system@2.0.0 uses.
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 265631b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
Hey @vinodkumarsharma276 thanks for this PR! You'll need to update the lock file. Did you make sure to check whether there were no breaking changes in 2.0.0 that could impact the package? |
ndelangen
reviewed
Jul 1, 2022
| @@ -72,7 +72,7 @@ | |||
| "chalk": "^4.1.0", | |||
| "core-js": "^3.8.2", | |||
| "express": "^4.17.1", | |||
| "file-system-cache": "^1.0.5", | |||
There was a problem hiding this comment.
This is great, but would you mind updating the lockfile with the PR too?
ndelangen
approved these changes
Jul 1, 2022
😮 whut ? |
ndelangen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using @storybook/core-common in our project and it pulls file-system@1.0.5 --> ramda@0.21.0. We need to use ramda@0.28.0 which file-system@2.0.0 uses.
Issue:
What I did
How to test
If your answer is yes to any of these, please make sure to include it in your PR.