-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade file-system-cache to 2.0.0 and remove custom types #18253
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
88648fd
Bump file-system to 2.0.0
vinodkumarsharma276 c27b003
fix lockfile
ndelangen 320a7a9
guess what?! the packages has typings now!! what a time to be alive!
ndelangen a32e15f
cleanup
ndelangen 26ae4a1
small fix
ndelangen 265631b
Merge branch 'next' into patch-1
ndelangen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,65 +1,8 @@ | ||
| // @ts-ignore - this package has no typings, so we wrap it and add typings that way, because we expose it | ||
| import Cache from 'file-system-cache'; | ||
|
|
||
| export interface Options { | ||
| basePath?: string; | ||
| ns?: string | string[]; | ||
| extension?: string; | ||
| } | ||
|
|
||
| export class FileSystemCache { | ||
| constructor(options: Options) { | ||
| this.internal = Cache(options) as any as FileSystemCache; | ||
| } | ||
|
|
||
| private internal: FileSystemCache; | ||
|
|
||
| path(key: string): string { | ||
| return this.internal.path(key); | ||
| } | ||
|
|
||
| fileExists(key: string): Promise<boolean> { | ||
| return this.internal.fileExists(key); | ||
| } | ||
|
|
||
| ensureBasePath(): Promise<void> { | ||
| return this.internal.ensureBasePath(); | ||
| } | ||
|
|
||
| get(key: string, defaultValue?: any): Promise<any | typeof defaultValue> { | ||
| return this.internal.get(key, defaultValue); | ||
| } | ||
|
|
||
| getSync(key: string, defaultValue?: any): any | typeof defaultValue { | ||
| return this.internal.getSync(key, defaultValue); | ||
| } | ||
|
|
||
| set(key: string, value: any): Promise<{ path: string }> { | ||
| return this.internal.set(key, value); | ||
| } | ||
|
|
||
| setSync(key: string, value: any): this { | ||
| this.internal.setSync(key, value); | ||
| return this; | ||
| } | ||
|
|
||
| remove(key: string): Promise<void> { | ||
| return this.internal.remove(key); | ||
| } | ||
|
|
||
| clear(): Promise<void> { | ||
| return this.internal.clear(); | ||
| } | ||
|
|
||
| save(): Promise<{ paths: string[] }> { | ||
| return this.internal.save(); | ||
| } | ||
|
|
||
| load(): Promise<{ files: Array<{ path: string; value: any }> }> { | ||
| return this.internal.load(); | ||
| } | ||
| } | ||
| export type Options = Parameters<typeof Cache>['0']; | ||
| export type FileSystemCache = ReturnType<typeof Cache>; | ||
|
|
||
| export function createFileSystemCache(options: Options): FileSystemCache { | ||
| return new FileSystemCache(options); | ||
| return Cache(options); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, but would you mind updating the lockfile with the PR too?