InteractionsAddon: Improve code quality by using title as FC & sharing state via useAddonState
#23291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
changed the title
FC & sharing state via useAddonState
ndelangen
changed the title
FC & sharing state via useAddonStateFC & sharing state via useAddonState
…e via useAddonState
ndelangen
force-pushed
the
norbert/improve-interaction-addon
branch
from
69fc710
to
0a1e471
Compare
…e-interaction-addon
…e-interaction-addon
…e-interaction-addon
…e-interaction-addon
…e-interaction-addon
|
Looks like something about vite + interactions is extremely flaky, I'll need to investigate. 😢 |
…e-interaction-addon
…ookjs/storybook into norbert/improve-interaction-addon
…e-interaction-addon
…e-interaction-addon
…e-interaction-addon
Base automatically changed from
norbert/ui-tabs-types-improvements
to
release/7.2
July 6, 2023 22:29
So… I discovered after a bunch of :computer-rage: ..
That the e2e test for interactions sometimes toggles the toolbar off.
When this happens it can’t click on the button to remount the story.
The toolbar disappears when playwright clicks on the addon tab, which appear like it refreshes storybook somehow, and then the toolbar disappears.
I cannot get playwright to do this locally, but I can see that something seems to be pressing t? Which toggles the toolbar.
What causes the refresh? what causes the toolbar to be toggle off? who knows?
I was trying to detect the presence of the toolbar to toggle back on, if needed,, and this is when things go weird.
Playwright tried to click the button, and can’t.. because it’s not visible.
So obviously I add a if statement, that if the button isn’t visible, it should do a procedure to ensure it will be, then try again.
Playwright tells me the button IS visible, but then when it tries to click says it isn’t. In addition using page.keyboard.press('t') doesn’t work to toggle the toolbar, very strange.
I even tried isWithinViewport()this suggests it’s in the viewport as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Telescoped off: #23288
What I did
useAddonStateFC, and connect to the same addon-stateHow to test
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]