-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InteractionsAddon: Improve code quality by using title as FC
& sharing state via useAddonState
#23291
Commits on Jul 4, 2023
-
improve interactions: make use of the title being a FC and share stat…
…e via useAddonState
Configuration menu - View commit details
-
Copy full SHA for 0a1e471 - Browse repository at this point
Copy the full SHA 0a1e471View commit details -
Merge branch 'norbert/ui-tabs-types-improvements' into norbert/improv…
…e-interaction-addon
Configuration menu - View commit details
-
Copy full SHA for a4b97a5 - Browse repository at this point
Copy the full SHA a4b97a5View commit details -
Merge branch 'norbert/ui-tabs-types-improvements' into norbert/improv…
…e-interaction-addon
Configuration menu - View commit details
-
Copy full SHA for 05d628a - Browse repository at this point
Copy the full SHA 05d628aView commit details -
Merge branch 'norbert/ui-tabs-types-improvements' into norbert/improv…
…e-interaction-addon
Configuration menu - View commit details
-
Copy full SHA for 210de88 - Browse repository at this point
Copy the full SHA 210de88View commit details -
Merge branch 'norbert/ui-tabs-types-improvements' into norbert/improv…
…e-interaction-addon
Configuration menu - View commit details
-
Copy full SHA for 09d0f55 - Browse repository at this point
Copy the full SHA 09d0f55View commit details
Commits on Jul 5, 2023
-
Merge branch 'norbert/ui-tabs-types-improvements' into norbert/improv…
…e-interaction-addon
Configuration menu - View commit details
-
Copy full SHA for 15f143b - Browse repository at this point
Copy the full SHA 15f143bView commit details
Commits on Jul 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b5072b2 - Browse repository at this point
Copy the full SHA b5072b2View commit details -
Merge branch 'norbert/ui-tabs-types-improvements' into norbert/improv…
…e-interaction-addon
Configuration menu - View commit details
-
Copy full SHA for 47c1356 - Browse repository at this point
Copy the full SHA 47c1356View commit details -
Merge branch 'norbert/improve-interaction-addon' of github.com:storyb…
…ookjs/storybook into norbert/improve-interaction-addon
Configuration menu - View commit details
-
Copy full SHA for b5818f4 - Browse repository at this point
Copy the full SHA b5818f4View commit details -
Merge branch 'norbert/ui-tabs-types-improvements' into norbert/improv…
…e-interaction-addon
Configuration menu - View commit details
-
Copy full SHA for 14184de - Browse repository at this point
Copy the full SHA 14184deView commit details -
Merge branch 'norbert/ui-tabs-types-improvements' into norbert/improv…
…e-interaction-addon
Configuration menu - View commit details
-
Copy full SHA for 4731d96 - Browse repository at this point
Copy the full SHA 4731d96View commit details -
Merge branch 'norbert/ui-tabs-types-improvements' into norbert/improv…
…e-interaction-addon
Configuration menu - View commit details
-
Copy full SHA for e6aa8c9 - Browse repository at this point
Copy the full SHA e6aa8c9View commit details
Commits on Jul 7, 2023
-
Hopefully stabilize interactions e2e test
So… I discovered after a bunch of :computer-rage: .. That the e2e test for interactions sometimes toggles the toolbar off. When this happens it can’t click on the button to remount the story. The toolbar disappears when playwright clicks on the addon tab, which appear like it refreshes storybook somehow, and then the toolbar disappears. I cannot get playwright to do this locally, but I can see that something seems to be pressing t? Which toggles the toolbar. What causes the refresh? what causes the toolbar to be toggle off? who knows? I was trying to detect the presence of the toolbar to toggle back on, if needed,, and this is when things go weird. Playwright tried to click the button, and can’t.. because it’s not visible. So obviously I add a if statement, that if the button isn’t visible, it should do a procedure to ensure it will be, then try again. Playwright tells me the button IS visible, but then when it tries to click says it isn’t. In addition using page.keyboard.press('t') doesn’t work to toggle the toolbar, very strange. I even tried isWithinViewport()this suggests it’s in the viewport as well.
Configuration menu - View commit details
-
Copy full SHA for 6436789 - Browse repository at this point
Copy the full SHA 6436789View commit details -
Configuration menu - View commit details
-
Copy full SHA for f524baa - Browse repository at this point
Copy the full SHA f524baaView commit details