Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InteractionsAddon: Improve code quality by using title as FC & sharing state via useAddonState #23291

Merged
merged 14 commits into from
Jul 7, 2023

Commits on Jul 4, 2023

  1. Configuration menu
    Copy the full SHA
    0a1e471 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a4b97a5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    05d628a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    210de88 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    09d0f55 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. Configuration menu
    Copy the full SHA
    15f143b View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2023

  1. Configuration menu
    Copy the full SHA
    b5072b2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    47c1356 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'norbert/improve-interaction-addon' of github.com:storyb…

    …ookjs/storybook into norbert/improve-interaction-addon
    ndelangen committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    b5818f4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    14184de View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4731d96 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e6aa8c9 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. Hopefully stabilize interactions e2e test

    So… I discovered after a bunch of :computer-rage: ..
    That the e2e test for interactions sometimes toggles the toolbar off.
    When this happens it can’t click on the button to remount the story.
    The toolbar disappears when playwright clicks on the addon tab, which appear like it refreshes storybook somehow, and then the toolbar disappears.
    I cannot get playwright to do this locally, but I can see that something seems to be pressing t? Which toggles the toolbar.
    What causes the refresh? what causes the toolbar to be toggle off? who knows?
    I was trying to detect the presence of the toolbar to toggle back on, if needed,, and this is when things go weird.
    Playwright tried to click the button, and can’t.. because it’s not visible.
    So obviously I add a if statement, that if the button isn’t visible, it should do a procedure to ensure it will be, then try again.
    Playwright tells me the button IS visible, but then when it tries to click says it isn’t. In addition using page.keyboard.press('t') doesn’t work to toggle the toolbar, very strange.
    I even tried isWithinViewport()this suggests it’s in the viewport as well.
    ndelangen committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    6436789 View commit details
    Browse the repository at this point in the history
  2. fixes for e2e tests

    ndelangen committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    f524baa View commit details
    Browse the repository at this point in the history