Angular: Fix enableProdMode setting

[valentinpalkovic]

Closes #28373

What I did

Prod mode is already applied conditionally here: https://github.com/storybookjs/storybook/blob/valentin/fix-prod-mode/code/frameworks/angular/src/preset.ts#L19. Therefore, it is not necessary to apply it a second time with a different condition.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

• stories
• unit tests
• integration tests
• end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

• Add or update documentation reflecting your changes
• If you are deprecating/removing a feature, make sure to update
  MIGRATION.MD

Checklist for Maintainers

• When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

• Make sure this PR contains one of the labels below:

  Available labels

  • bug: Internal changes that fixes incorrect behavior.
  • maintenance: User-facing maintenance tasks.
  • dependencies: Upgrading (sometimes downgrading) dependencies.
  • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
  • cleanup: Minor cleanup style change. Will not show up in release changelog.
  • documentation: Documentation only changes. Will not show up in release changelog.
  • feature request: Introducing a new feature.
  • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
  • other: Changes that don't fit in the above categories.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-28415-sha-49a96170. Try it out in a new sandbox by running npx storybook@0.0.0-pr-28415-sha-49a96170 sandbox or in an existing project with npx storybook@0.0.0-pr-28415-sha-49a96170 upgrade.

More information

Published version	0.0.0-pr-28415-sha-49a96170
Triggered by	@valentinpalkovic
Repository	storybookjs/storybook
Branch	valentin/fix-prod-mode
Commit	49a96170
Datetime	Tue Jul 2 09:40:17 UTC 2024 (1719913217)
Workflow run	9758625275

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=28415

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a61d756. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 1 target

• nx run-many -t build --parallel=3

---

Sent with 💌 from NxCloud.

[kroeder]

Ah good catch! I didn't knew there is another import and thought we somehow have to get the config args into the file you removed the code from

LGTM, thanks for the fast fix!

[greptile-apps]

PR Summary

• Removed redundant constructor enabling production mode based on NODE_ENV
• Ensure production mode is applied only once in the codebase

No major changes found since last review.

_{1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings}