Clean usage of @types/webpack-env
dep in all packages
#9536
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #7855
What I did
Clean usage of
@types/webpack-env
dep in all packages:@types/webpack-env
must be defined asdependencies
in packages that export a type/function using typings from@types/webpack-env
(it is oftenNodeModule
). In that case/// <reference types="webpack-env" />
is present in some files of thedist
folder of the lib. Example:lib/client-api
.@types/webpack-env
must be defined asdevDependencies
in packages that use its typings internally but does not expose anything related to it. Many addons need the types because they usemodule.hot
function. Example:addons/a11y
webpack-env
should be removed from "compilerOptions.types" key oftsconfig.json
of packages that don't need it.I also bump
@types/webpack-env
to^1.15.0
to have the same version all across the monorepo.