Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean usage of @types/webpack-env dep in all packages #9536

Merged
merged 1 commit into from
Jan 20, 2020
Merged

Commits on Jan 20, 2020

  1. fix: clean usage of @types/webpack-env dep in all packages

     - `@types/webpack-env` must be defined as `dependencies` in packages that export a type/function using typings from `@types/webpack-env` (it is often `NodeModule`). In that case `/// <reference types="webpack-env" />` is present in some files of the `dist` folder of the lib. Example: `lib/client-api`.
     - `@types/webpack-env` must be defined as `devDependencies` in packages that use its typings internally but does not expose anything related to it. Many addons need the type because they use `module.hot` function. Example: `addons/a11y`
     - `webpack-env` should be removed from "compilerOptions.types" key of `tsconfig.json` of packages that don't need it.
    
     I also bump `@types/webpack-env` to ^1.15.0 to have the same version all across the monorepo
    gaetanmaisse committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    36ee762 View commit details
    Browse the repository at this point in the history