-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit IPAccount Storage Writes to Registered Modules #103
Limit IPAccount Storage Writes to Registered Modules #103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general, is there any security risk with create3 to deploy the accountimpl? do we want to use the same accountimpl cross multiple chains?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: would be cleaner to check in CREATE3 code in #104
please rebase the code. |
2d2ee14
to
dcb4f8f
Compare
Rebased |
This pull request introduces changes to the IPAccount storage. Here's a brief overview of the changes:
We have now limited the ability to write into the IPAccount storage. With this update, only register modules and core registries will have the write access.
Closes #84