Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit IPAccount Storage Writes to Registered Modules #103

Merged
merged 4 commits into from
Apr 15, 2024

Conversation

kingster-will
Copy link

@kingster-will kingster-will commented Apr 15, 2024

This pull request introduces changes to the IPAccount storage. Here's a brief overview of the changes:

We have now limited the ability to write into the IPAccount storage. With this update, only register modules and core registries will have the write access.

Closes #84

Copy link
Member

@LeoHChen LeoHChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, is there any security risk with create3 to deploy the accountimpl? do we want to use the same accountimpl cross multiple chains?

Copy link

@jdubpark jdubpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: would be cleaner to check in CREATE3 code in #104

contracts/IPAccountStorage.sol Show resolved Hide resolved
test/foundry/IPAccountStorage.t.sol Show resolved Hide resolved
@LeoHChen
Copy link
Member

please rebase the code.

@kingster-will kingster-will changed the title Limit IPAccount Storage Writes to Registered Modules and Introduce CREATE3 Limit IPAccount Storage Writes to Registered Modules Apr 15, 2024
@kingster-will
Copy link
Author

please rebase the code.

Rebased

@LeoHChen LeoHChen merged commit 6d7bed4 into storyprotocol:main Apr 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Anyone can write to any IPAccounts using their namespace
3 participants