Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduction of CREATE3 for Deployment to Deterministic Addresses to Resolve Cyclical Dependencies #104

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

kingster-will
Copy link

This PR introduces an enhancement to our deployment process with the introduction of CREATE3. Here's a brief overview of the changes:

  1. Introduction of CREATE3: We have introduced CREATE3, a feature that allows deployment to a deterministic address using only a salt. This is a major advancement in resolving cyclical dependencies within our system.

  2. Immutable Addresses for Dependencies: The introduction of CREATE3 allows us to store dependencies as immutable addresses. This eliminates the need for governed functions to set these addresses, further simplifying our protocol.

  3. Simplified Protocol Post Configurations: No need to configure dependencies' addresses through the governance process after deployment.

Copy link

@jdubpark jdubpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems duplicate of commits from #103, we can merge this one and rebase #103 to skip dup commits.

@LeoHChen LeoHChen merged commit f7ddbdf into storyprotocol:main Apr 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants