Refactor Governance into AccessManager #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ramarti
requested review from
kingster-will,
leeren,
jdubpark,
Spablob,
LeoHChen and
AndyBoWu
as code owners
jdubpark
reviewed
Apr 10, 2024
jdubpark
reviewed
Apr 10, 2024
jdubpark
reviewed
Apr 10, 2024
jdubpark
reviewed
Apr 10, 2024
LeoHChen
reviewed
Apr 10, 2024
LeoHChen
reviewed
Apr 10, 2024
LeoHChen
reviewed
Apr 10, 2024
LeoHChen
approved these changes
Apr 10, 2024
kingster-will
approved these changes
Apr 10, 2024
AndyBoWu
pushed a commit
that referenced
this pull request
Apr 11, 2024
* refactor Governance into AccessManager * remove view method in script
AndyBoWu
pushed a commit
that referenced
this pull request
Apr 11, 2024
* refactor Governance into AccessManager * remove view method in script
AndyBoWu
pushed a commit
that referenced
this pull request
Apr 11, 2024
* refactor Governance into AccessManager * remove view method in script
LeoHChen
pushed a commit
that referenced
this pull request
Apr 12, 2024
* Refactor Governance into AccessManager (#43) * refactor Governance into AccessManager * remove view method in script * [feat] add reusable forge code coverage workflow --------- Co-authored-by: Ramarti <raul.mf86@gmail.com>
Spablob
pushed a commit
to Spablob/protocol-core-v1
that referenced
this pull request
Apr 12, 2024
* Refactor Governance into AccessManager (storyprotocol#43) * refactor Governance into AccessManager * remove view method in script * [feat] add reusable forge code coverage workflow --------- Co-authored-by: Ramarti <raul.mf86@gmail.com>
jdubpark
pushed a commit
to jdubpark/sp-protocol-core
that referenced
this pull request
Apr 14, 2024
* Refactor Governance into AccessManager (storyprotocol#43) * refactor Governance into AccessManager * remove view method in script * [feat] add reusable forge code coverage workflow --------- Co-authored-by: Ramarti <raul.mf86@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
setGovernance()setGovernancebeing substituted withAccessManager.setAuthority()causes Governance and Governable to be redundant. We remove them in favor of using the OZ contracts as they come.Next PR: