Interface for LocalCosigner #67
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interface for threshold-signature
Add files via upload
agouin
reviewed
Mar 21, 2022
There was a problem hiding this comment.
Great first pass! Creating the LocalThresholdSignatureImplementation (or similar) in a new file and moving the ThresholdEd25519Signature interface method implementations there will help cleanup the LocalCosigner file so that it will be more generic in application to either a "local" threshold ed25519 signature implementation, or a hardware implementation that will be added in the future.
Merge Upstream
|
Not the best work I have done but always a start :) |
agouin
reviewed
May 9, 2022
agouin
reviewed
May 9, 2022
Some update regarding mutex
To keep align with upstream main
To keep up with upstream main
Add logs for participating cosigners (strangelove-ventures#111)
Threshold parameter validation (strangelove-ventures#112)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation and some "refactoring" in to have a Threshold interface. Will potentially enable/ease implementation for other LocalCosigners like HSM etc.