Apply some best practices to Dockerfile #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use alpine image instead of golang for earliest stage, which did not use anything from the golang image. Use apk add --no-cache per convention inside Dockerfiles, which does not store apk's package cache on disk. This reduced the final image size by about 3MB. Move apk add package arguments to their own lines, so that diffs are trivial to follow as individual packages are added or removed. Validate checksum of downloaded dasel binary, to avoid a potential supply chain attack. Further possible improvements: - Validate checksum of musl download - Maybe point at a fixed tag of boxboat/config-merge - Maybe download gzipped dasel binaries instead of raw binaries - Update to newer point release of dasel - Unify the two Dockerfiles by a top-level build arg to switch between the alternative "busybox-min" stages
DavidNix
approved these changes
Oct 27, 2022
agouin
approved these changes
Oct 27, 2022
agouin
reviewed
Oct 27, 2022
| @@ -39,7 +48,13 @@ FROM boxboat/config-merge:latest as config-merge | |||
|
|
|||
| FROM golang:1.19-alpine | |||
There was a problem hiding this comment.
Now that I think about it, there doesn't seem to be a reason to have golang in the final image either
There was a problem hiding this comment.
I was guessing that it was important for downstream builders. I'll open a followup PR for that, in case it ends up breaking anything (unlikely).
mark-rushakoff
added a commit
that referenced
this pull request
Oct 27, 2022
Discusssion in #3 says that the final image didn't need golang.
mark-rushakoff
added a commit
that referenced
this pull request
Oct 27, 2022
Discussion in #3 says that the final image didn't need golang.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use alpine image instead of golang for earliest stage, which did not use anything from the golang image.
Use apk add --no-cache per convention inside Dockerfiles, which does not store apk's package cache on disk. This reduced the final image size by about 3MB.
Move apk add package arguments to their own lines, so that diffs are trivial to follow as individual packages are added or removed.
Validate checksum of downloaded dasel binary, to avoid a potential supply chain attack.
Further possible improvements: