Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply some best practices to Dockerfile #3

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Apply some best practices to Dockerfile #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 28 additions & 8 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,15 @@
FROM --platform=$BUILDPLATFORM golang:1.19-alpine AS busybox-min
FROM --platform=$BUILDPLATFORM alpine:3 AS busybox-min

RUN apk add --update --no-cache wget curl make git libc-dev bash gcc linux-headers eudev-dev
RUN apk add --no-cache \
bash \
curl \
eudev-dev \
gcc \
git \
libc-dev \
linux-headers \
make \
wget

ARG TARGETARCH
ARG BUILDARCH
Expand Down Expand Up @@ -39,7 +48,13 @@ FROM boxboat/config-merge:latest as config-merge

FROM golang:1.19-alpine
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I think about it, there doesn't seem to be a reason to have golang in the final image either

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was guessing that it was important for downstream builders. I'll open a followup PR for that, in case it ends up breaking anything (unlikely).


RUN apk add wget curl lz4 nano jq npm
RUN apk add --no-cache \
curl \
jq \
lz4 \
nano \
npm \
wget

# Install busybox
COPY --from=busybox-min /busybox/busybox /busybox/busybox
Expand All @@ -49,11 +64,16 @@ COPY --from=config-merge /usr/local/config-merge /usr/local/config-merge
COPY --from=config-merge /usr/local/bin/config-merge /usr/local/bin/config-merge
COPY --from=config-merge /usr/local/bin/envsubst /usr/local/bin/envsubst

# Add dasel
# Add dasel.
# The dasel repository does not post checksums of the published binaries,
# so use hardcoded binaries in order to avoid potential supply chain attacks.
# Note, dasel does publish docker images, but only for amd64,
# so we cannot copy the binary out like we do for config-merge.
RUN if [ "$(uname -m)" = "aarch64" ]; then \
ARCH=arm64; \
ARCH=arm64 DASELSUM="8e1f95b5f361f68ed8376d5a9593ae4249e28153a05b26f1f99f9466efeac5c9 /usr/local/bin/dasel"; \
else \
ARCH=amd64; \
ARCH=amd64 DASELSUM="3efd202a525c43c027bddc770861dd637ec8389a4ca3ef2951da7165350219ed /usr/local/bin/dasel"; \
fi; \
wget -O /usr/local/bin/dasel https://github.com/TomWright/dasel/releases/download/v1.26.0/dasel_linux_$ARCH
RUN chmod +x /usr/local/bin/dasel
wget -O /usr/local/bin/dasel https://github.com/TomWright/dasel/releases/download/v1.26.0/dasel_linux_$ARCH && \
sha256sum -c <(echo "$DASELSUM") && \
chmod +x /usr/local/bin/dasel
38 changes: 29 additions & 9 deletions native.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,15 @@
FROM golang:1.19-alpine AS busybox-min

RUN apk add --update --no-cache wget curl make git libc-dev bash gcc linux-headers eudev-dev
FROM alpine:3 AS busybox-min

RUN apk add --no-cache \
bash \
curl \
eudev-dev \
gcc \
git \
libc-dev \
linux-headers \
make \
wget

# Build minimal busybox
WORKDIR /
Expand All @@ -14,7 +23,13 @@ FROM boxboat/config-merge:latest as config-merge

FROM golang:1.19-alpine

RUN apk add wget curl lz4 nano jq npm
RUN apk add --no-cache \
curl \
jq \
lz4 \
nano \
npm \
wget

# Install busybox
COPY --from=busybox-min /busybox/busybox /busybox/busybox
Expand All @@ -24,11 +39,16 @@ COPY --from=config-merge /usr/local/config-merge /usr/local/config-merge
COPY --from=config-merge /usr/local/bin/config-merge /usr/local/bin/config-merge
COPY --from=config-merge /usr/local/bin/envsubst /usr/local/bin/envsubst

# Add dasel
# Add dasel.
# The dasel repository does not post checksums of the published binaries,
# so use hardcoded binaries in order to avoid potential supply chain attacks.
# Note, dasel does publish docker images, but only for amd64,
# so we cannot copy the binary out like we do for config-merge.
RUN if [ "$(uname -m)" = "aarch64" ]; then \
ARCH=arm64; \
ARCH=arm64 DASELSUM="8e1f95b5f361f68ed8376d5a9593ae4249e28153a05b26f1f99f9466efeac5c9 /usr/local/bin/dasel"; \
else \
ARCH=amd64; \
ARCH=amd64 DASELSUM="3efd202a525c43c027bddc770861dd637ec8389a4ca3ef2951da7165350219ed /usr/local/bin/dasel"; \
fi; \
wget -O /usr/local/bin/dasel https://github.com/TomWright/dasel/releases/download/v1.26.0/dasel_linux_$ARCH
RUN chmod +x /usr/local/bin/dasel
wget -O /usr/local/bin/dasel https://github.com/TomWright/dasel/releases/download/v1.26.0/dasel_linux_$ARCH && \
sha256sum -c <(echo "$DASELSUM") && \
chmod +x /usr/local/bin/dasel