Make metadata allocation eager and leave data allocation lazy #3097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbaublitz
force-pushed
the
thinp-rework
branch
4 times, most recently
from
48cc4be to
a5e9a35
Compare
mulkieran
requested changes
Sep 13, 2022
jbaublitz
force-pushed
the
thinp-rework
branch
from
fd26039 to
d9e048e
Compare
bmr-cymru
reviewed
Sep 20, 2022
bmr-cymru
reviewed
Sep 22, 2022
| data_extend_size: Sectors, | ||
| ) -> StratisResult<Sectors> { | ||
| thinpooldev.suspend(get_dm(), DmOptions::default())?; | ||
|
|
There was a problem hiding this comment.
What happens in the event of an error in this function? Either one of the not Ok(Some(transaction)) branches, or an early return from say commit_alloc()?
What performs the resume on the thinpooldev, or is it left suspended in that case?
Since we don't start manipulating the thinpooldev until the Ok(Some(...)) branch could the suspend me moved into that branch, leaving the error cases a no-op wrt to the device state?
bmr-cymru
approved these changes
Sep 26, 2022
mulkieran
approved these changes
Sep 26, 2022
|
@jbaublitz Plz rebase and squash as you like and I'll merge. |
|
@mulkieran We decided we'd address this: in another PR, right? |
Yes. That was my understanding. |
This commit builds on the previous thin provisioning rework. The simplified, eager metadata allocation allows us to decrease fragmentation introduced into the previous change and the lazy data allocation allows us to provide users with the same flexibility around changing requirements that we previously provided.
jbaublitz
force-pushed
the
thinp-rework
branch
from
d9e048e to
2b828ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3086