Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder suspend and resume when extending thin devices #3225

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

jbaublitz
Copy link
Member

Closes #3125
Related to #3097

@jbaublitz jbaublitz requested a review from mulkieran January 12, 2023 14:59
@jbaublitz jbaublitz self-assigned this Jan 12, 2023
Copy link
Member

@mulkieran mulkieran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks right, but I think comments noted inline are obsolete.

src/engine/strat_engine/thinpool/thinpool.rs Show resolved Hide resolved
src/engine/strat_engine/thinpool/thinpool.rs Show resolved Hide resolved
@jbaublitz jbaublitz force-pushed the issue-stratisd-3097 branch from 13137d9 to a5c2a70 Compare January 12, 2023 21:24
This allows more resilience against cases where there are failures and
ensures that the thin pool will be left in a resumed state as often as
possible.
@mulkieran mulkieran merged commit bffb9a2 into stratis-storage:master Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error handling for suspend/resume in the thin pool
2 participants