This repository has been archived by the owner on Aug 16, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 312
[FS] Sidechains coming in with history #3287
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Imported from Changeset 124
Imported from Changeset 130
Imported from Changeset 134
Imported from Changeset 135
Imported from Changeset 136
Imported from Changeset 137
Imported from Changeset 140
Imported from Changeset 146
Imported from Changeset 147
Imported from Changeset 150
Imported from Changeset 152
Imported from Changeset 154
Imported from Changeset 155
Imported from Changeset 156
Imported from Changeset 157
Imported from Changeset 159
Imported from Changeset 160
Imported from Changeset 161
Imported from Changeset 162
Imported from Changeset 163
Imported from Changeset 164
Imported from Changeset 165
Imported from Changeset 166
Imported from Changeset 167
Imported from Changeset 168
Imported from Changeset 169
Imported from Changeset 170
Imported from Changeset 171
Imported from Changeset 172
Imported from Changeset 173
The IsFederationActive call takes 961 ms (almost a full second). This PR adds a cache of parameters / result values.
* Moved coinbase text out of the CreateGenesis method * removed some unused variables * Brought the name and cointicker of the networks inline with the definition of the networks * Brought some more network data for Main inline * Upgrade # of coins to 100M * Create new genesis block for Main
* Add Api endpoint to show federation history * Clean up warning and associated code style * Remove newline * Remove space * Use StringBuilder
* nuget package only exists for net451 * no need for Test SDK on this exe project
This removes the WithdrawalHistoryProvider class.
The MainChain_To_SideChain test is being a bit sporadic for me, but it has been passing.
* moved fed controller tests file * init test * Moved BuildErrorResponse to base class * Added 3 tests * 3 more tests
* Create .gitattributes * Fix CR problem?
Merging fedgateway in
Please wait before committing this, i'd like to bump build version before and after this goes in. |
* Move transaction building out to own class. * Add Guard, only for consistency * Add to DI.
bokobza
approved these changes
Mar 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the PR to come from a branch inside this repo so we can continue PR process whilst developing sidechains.
This will be blocked until the FN release.
Remember when merging this eventually to use the 'merge with history' option :)