This repository has been archived by the owner on Aug 16, 2021. It is now read-only.
Make AccountName param optional in API calls #3816
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeptin
reviewed
Jul 18, 2019
| /// The name of the account for which to get the extended public key. | ||
| [Required] | ||
| /// /// <summary> |
There was a problem hiding this comment.
Suggested change
| /// /// <summary> | |
| /// </summary> |
|
Looks like this broke some tests @maciejzaleski - want one of us to take a look at it? Would approve the change otherwise, but would also be nice to just have a const referenced rather than the same string duplicated |
|
Replacing with #3831 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.