This repository has been archived by the owner on Aug 16, 2021. It is now read-only.
[Wallet] Make account param optional in API with consts and passing tests #3831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#3286) * Corrected logic for PowNoRetargeting/PosNoRetargeting * Act on the review * Act on review
…ciejzaleski/StratisBitcoinFullNode into maciejzaleski-MakeAccountParamOptionalInAPI
fassadlr
reviewed
Jul 23, 2019
fassadlr
reviewed
Jul 23, 2019
| @@ -27,6 +27,9 @@ namespace Stratis.Bitcoin.Features.Wallet | |||
| /// </summary> | |||
| public class WalletManager : IWalletManager | |||
| { | |||
| /// <summary>Used to get the first account.</summary> | |||
| public const string DefaultAccount = "account 0"; | |||
There was a problem hiding this comment.
Awesome I love these kinds of PRs.
fassadlr
reviewed
Jul 23, 2019
fassadlr
approved these changes
Jul 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To replace #3816